-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[refactor] Migrate from Mocha+Chai to Jest #6079
Commits on Oct 12, 2018
-
[refactor] Migrate from Mocha+Chai to Jest
This change migrates all the existing unit tests - to Jest's global expect and matchers from chai's imported expect, asserts and matchers. - to Jest's describe/test from mocha's describe/it The majority of the mechanical changes to tests are achieved through running jest-codemods. The only two note-worthy manual tweaks: 1. Setting a testURL of http://localhost in jest config and adjusting a few tests to leverage this value instead of relying on about:blank. 2. Re-enabling ExploreChartPanel_spec which was previously commented out as we cannot have empty tests with nothing in it with Jest. :) This change also removes dependencies to Mocha and Chai.
Configuration menu - View commit details
-
Copy full SHA for aeb5eb0 - Browse repository at this point
Copy the full SHA aeb5eb0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5fffcf3 - Browse repository at this point
Copy the full SHA 5fffcf3View commit details -
Fixing lint errors. The diff looks large but is large done through `y…
…arn run lint --fix` The only noteworthy change is the one in eslintrc for tests. The env has been updated from mocha to jest.
Configuration menu - View commit details
-
Copy full SHA for 632f92c - Browse repository at this point
Copy the full SHA 632f92cView commit details -
Adding eslint-plugin-jest and further modify tests.
- One small fix in sqllab's Timer Spec for a test that is not using the spy it created for testing. - Deletion of a duplicated test caught by eslint-plugin-jest.
Configuration menu - View commit details
-
Copy full SHA for 4606334 - Browse repository at this point
Copy the full SHA 4606334View commit details -
- Make istanbul coverage work with Jest.
- Remove dependency on stand-alone istanbul and babel-istanbul as they're built-into jest. Yes!
Configuration menu - View commit details
-
Copy full SHA for 3437946 - Browse repository at this point
Copy the full SHA 3437946View commit details -
Configuration menu - View commit details
-
Copy full SHA for b768f36 - Browse repository at this point
Copy the full SHA b768f36View commit details -
Configuration menu - View commit details
-
Copy full SHA for c4fc33c - Browse repository at this point
Copy the full SHA c4fc33cView commit details
Commits on Oct 13, 2018
-
- tweaking maxworkers for travis and specifying coverageDirectory for…
… codecov - remove dynamic import in shim.js now that it is set in babelrc for tests only.
Configuration menu - View commit details
-
Copy full SHA for 1dfe55f - Browse repository at this point
Copy the full SHA 1dfe55fView commit details