Map visualization #650
Map visualization #650
Conversation
| "Choice of [Point Radius] must be present in [Group By]") | ||
|
|
||
| if (fd.get('all_columns_x') not in fd.get('groupby') or | ||
| fd.get('all_columns_y') not in fd.get('groupby')): |
There was a problem hiding this comment.
nit: indent within condition should not match block bellow
|
Coverage increased (+0.03%) to 81.446% when pulling aaa1a57ff175360f78930594569f94174e183a39 on georgeke:maps_v1 into 30da408 on airbnb:master. |
|
Coverage increased (+0.04%) to 81.464% when pulling e40e68838675b2ec4c962d99d61e515f5fb1f2e9 on georgeke:maps_v1 into 30da408 on airbnb:master. |
| import supercluster from 'supercluster'; | ||
| import ViewportMercator from 'viewport-mercator-project'; | ||
|
|
||
| const earthCircumferenceKm = 40075.16; |
There was a problem hiding this comment.
could use SCREAMING_SNAKE_CASE for constants. EARTH_CIRCUMFERENCE_KM
|
Coverage increased (+0.04%) to 81.458% when pulling d35d97d24e121fd0ec189d30a7d833b531b7401a on georgeke:maps_v1 into 30da408 on airbnb:master. |
| const earthCircumferenceKm = 40075.16; | ||
|
|
||
| class ScatterPlotGlowOverlay extends ScatterPlotOverlay { | ||
| _kmToPixels(kilometers, latitude, zoomLevel) { |
There was a problem hiding this comment.
have you considered pulling _kmToPixels and _isNumeric in to a mapUtils file, so we can share them with other map visualizations in the future...
There was a problem hiding this comment.
should this be _kmPerPixels?
There was a problem hiding this comment.
per seems more fitting for a multiplier constant whilst to I think is better for a function. As in given kilometers, the function converts it to pixels. Which reminds me, I should change milesToKm to milesPerKm
|
Coverage increased (+0.04%) to 81.458% when pulling 06ca7969272dd1975b15797df2913791700f19da on georgeke:maps_v1 into 30da408 on airbnb:master. |
use react-map-gl superclustering of long/lat points Added hook for map style, huge performance boost from bounding box fix, added count text on clusters variable gradient size based on metric count Ability to aggregate over any point property This needed a change in the supercluster npm module, a PR was placed here: mapbox/supercluster#12 Aggregator function option in explore, tweaked visual defaults better radius size management clustering radius, point metric/unit options scale cluster labels that don't fit, non-numeric labels for points Minor fixes, label field affects points, text changes serve mapbox apikey for slice global opacity, viewport saves (hacky), bug in point labels fixing mapbox-gl dependency mapbox_api_key in config expose row_limit, fix minor bugs Add renderWhileDragging flag, groupby. Only show numerical columns for point radius Implicitly group by lng/lat columns and error when label doesn't match groupby 'Fix' radius in miles problem, still some jankiness derived fields cannot be typed as of now -> reverting numerical number change better grouping error checking, expose count(*) for labelling Custom colour for clusters/points + smart text colouring Fixed bad positioning and overflow in explore view + small bugs + added thumbnail
mistercrunch
added
🏷️ bot
Using Mapbox GL JS.
Features: