Lookup and Extraction Dimensions query and filter support #7030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fixed the cache issue for bignumber * fixed (cherry picked from commit 8e2d28d)
(cherry picked from commit cb55668)
Since #6287 and effectively moving to a new version of d3, d3-format and d3-time-format raises when receiving invalid input strings. This code wraps the potential issues inside `try` blocks that will effectively return an `ERROR` string as output to the formatting function. (cherry picked from commit 4690563)
(cherry picked from commit ec1316a)
(cherry picked from commit 8c4f723)
* Fix adhoc metrics in Polygon * Addressing comments (cherry picked from commit 4c94447)
* [bugfix] deck.gl grid&hex don't respond to zoom&drag Following recent changes, Hex & Grid component wouldn't respond to viewport interactions. This fixes the issue. This PR also greatly improve rendering performance by only recomputing the deck.gl layers when needed, as opposed to every time the viewport changes, which is very inneficient. Note that most other deck.gl layers seem to be systematically recomputing layers, we'll have to fix this in another PR. * Addressing comments (cherry picked from commit 8177fa1)
(cherry picked from commit e469086)
* Display raw value in addition to ERROR * update unit test (cherry picked from commit 3c6e882)
(cherry picked from commit 2489876)
* removing india country map which is 12MB+ * removing src/ in general, keeping the countries folder which has geo data (cherry picked from commit 321c2e1)
|
@john-bodley okay I'll pull master over, test my changes and re-submit eventually. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fix:
The main branch from which the code is branched is 0.30 (v0.30.0rc12). This because since 0.31 onwards, the Druid models seems to be broken (see #6780). So not sure what would be the path to merge into master.
The PyDruid requirement has been changed to reflect inclusion of Registered Lookup class as in Registered lookups #153
Also there is quite a bit of code for issuing the Druid query, (e.g. using "Phase 1" and "Phase 2" queries). Can someone explain to me the reasons behind that? I can help in cleaning up and refactoring