Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Time Grain and Added Drill to README #7635

Merged
merged 2 commits into from
Jun 2, 2019

Conversation

cgivre
Copy link
Contributor

@cgivre cgivre commented Jun 2, 2019

CATEGORY

Choose one

  • Bug Fix
  • Enhancement (new features, refinement)
  • Refactor
  • Add tests
  • Build / Development Environment
  • Documentation

SUMMARY

This PR fixes a small bug in the time grains for Apache Drill and adds Drill to the README file.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

REVIEWERS

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Total nit, but while we're at it, perhaps nearestdate should be NEARESTDATE in all grains as per typical SQL uppercasing convention?

@codecov-io
Copy link

codecov-io commented Jun 2, 2019

Codecov Report

Merging #7635 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7635   +/-   ##
=======================================
  Coverage   65.53%   65.53%           
=======================================
  Files         435      435           
  Lines       21726    21726           
  Branches     2393     2393           
=======================================
  Hits        14239    14239           
  Misses       7365     7365           
  Partials      122      122
Impacted Files Coverage Δ
superset/db_engine_specs.py 67.23% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1dc17f3...7a98bc0. Read the comment docs.

@cgivre
Copy link
Contributor Author

cgivre commented Jun 2, 2019

@villebro
Fixed.

@villebro villebro merged commit 257c100 into apache:master Jun 2, 2019
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.34.0 labels Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 0.34.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants