Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Switzerland to country selection #8592

Merged
merged 1 commit into from
Nov 18, 2019
Merged

add Switzerland to country selection #8592

merged 1 commit into from
Nov 18, 2019

Conversation

Caahlo
Copy link
Contributor

@Caahlo Caahlo commented Nov 18, 2019

add Switzerland to country selection and document Swiss cantons as regions

CATEGORY

Choose one

  • Bug Fix
  • Enhancement (new features, refinement)
  • Refactor
  • Add tests
  • Build / Development Environment
  • Documentation

SUMMARY

Add Switzerland to the documentation and to the country map drop-down menu
requires: apache-superset/superset-ui-plugins#260

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screenshot (7)

TEST PLAN

  1. Go to the charts list
  2. Click on the "Birth in France by department in 2016" link
  3. under "Options" in the "Country Name" drop-down menu, select "Switzerland"

Expected

The borders of the cantons of switzerland should appear in pale gray.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

REVIEWERS

add Switzerland to country selection and document Swiss cantons as regions
@codecov-io
Copy link

codecov-io commented Nov 18, 2019

Codecov Report

Merging #8592 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #8592   +/-   ##
======================================
  Coverage    66.5%   66.5%           
======================================
  Files         450     450           
  Lines       23120   23120           
  Branches     2453    2453           
======================================
  Hits        15376   15376           
  Misses       7595    7595           
  Partials      149     149
Impacted Files Coverage Δ
superset/assets/src/explore/controls.jsx 42.18% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ee08c9...3472023. Read the comment docs.

@mistercrunch mistercrunch merged commit c87a140 into apache:master Nov 18, 2019
@Caahlo Caahlo deleted the add_switzerland branch November 19, 2019 12:41
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.36.0 labels Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 0.36.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants