[SYSTEMDS-????] rewrite nary elementwise mult #2105
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2105 +/- ##
============================================
- Coverage 70.66% 70.65% -0.02%
- Complexity 42231 42258 +27
============================================
Files 1441 1441
Lines 162417 162501 +84
Branches 31654 31682 +28
============================================
+ Hits 114777 114813 +36
- Misses 38660 38711 +51
+ Partials 8980 8977 -3 ☔ View full report in Codecov by Sentry. |
squashed: - fixed bug in nary hop, where output value type was computed wrongfully in case of scalars with mixed value types - fixed bug in nary hop, where output is wrongfully set as scalar - clean up & fixed the aggregate ternary rewrite to also work nary mult & fixed the n* lineage issue - increased code coverage for rewrite ternary aggregate: colsum(A^3)
e-strauss
force-pushed
the
NARY_ELEM_MULT
branch
from
b74e76a
to
ea8a890
Compare
e-strauss
commented
Sep 13, 2024
src/test/java/org/apache/sysds/test/functions/ternary/TernaryAggregateTest.java
Show resolved
Hide resolved
e-strauss
commented
Sep 13, 2024
| @@ -180,6 +182,36 @@ public void testTernaryAggregateCDenseMatrixCPNoRewrite() { | |||
| public void testTernaryAggregateCSparseMatrixCPNoRewrite() { | |||
| runTernaryAggregateTest(TEST_NAME2, true, false, false, ExecType.CP); | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
added a new test cases for rewrite colsum(A^3) to improve code coverage
|
LGTM - thanks for the patch @e-strauss and the holistic cleanup. During the merge I only replaced the unrolled loop in |
|
thanks, yes makes sense |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds the nary the rewrite and operator for elementwise multiply