[MINOR] Python API: removal of enum output_type #2119

e-strauss · 2024-09-24T20:46:42Z

this PR removes the redundant information about the datatype from the python DAGNodes, the datatype can be instead inferred from the instance class and the value type directly from the Java object

src/main/python/systemds/operator/operation_node.py

e-strauss · 2024-09-25T07:44:32Z

src/main/python/systemds/operator/nodes/list.py

-    def code_line(self, var_name: str, unnamed_input_vars: Sequence[str],
-                  named_input_vars: Dict[str, str]) -> str:
-        code_line = super().code_line(var_name, unnamed_input_vars, named_input_vars)
-        return code_line
-


removed since we call anyways the super class method, so no need to overwrite imo

src/main/python/systemds/operator/nodes/matrix.py

src/main/python/systemds/operator/nodes/multi_return.py

src/main/python/systemds/operator/nodes/source.py

e-strauss · 2024-09-25T07:57:35Z

src/main/python/systemds/operator/operation_node.py

+
+    def data_type(self):
+        return "operation_node"
+


can be removed, artefact from an older approach

if we can remove it, lets.

src/main/python/systemds/context/systemds_context.py

Baunsgaard

LGTM, if the tests pass, then feel free to merge it.

e-strauss marked this pull request as draft September 24, 2024 20:55

e-strauss force-pushed the value_type_enum branch 2 times, most recently from 5d1d1f2 to e244d90 Compare September 24, 2024 22:29

e-strauss marked this pull request as ready for review September 24, 2024 23:20

e-strauss requested a review from Baunsgaard September 24, 2024 23:21