THRIFT-3622: remove auto_ptr use in the codebase because it is deprecated #1183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The build failure is about node.js version dependencies which curiously is in an unrelated but active pull request for THRIFT-4074. There were no errors in Travis CI to worry about here; waiting for Appveyor before merging. |
|
Build job #7 failed because it failed to download something from a site I can get to just fine (github, holding "phantomjs"). Not related to the PR. |
jeking3
added a commit
to jeking3/thrift
that referenced
this pull request
Nov 30, 2017
…ated Client: C++ This closes apache#1183
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.