Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

THRIFT-4838: Add unix socket support for Swift #2766

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kinoroy
Copy link
Contributor

@kinoroy kinoroy commented Mar 6, 2023

  • Did you create an Apache Jira ticket? (Request account here, not required for trivial changes)
  • If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
  • Did you squash your changes to a single commit? (not required, but preferred)
  • Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"?
  • If your change does not involve any code, include [skip ci] anywhere in the commit message to free up build resources.

What

Adds unix domain sockets as a low level transport option for the Swift library

Why

To improve Swift language support in Thrift.

This change will, for example, enable the use of the popular OSQuery library natively in Swift (currently only supports Obj-C++)

How

Extend the existing TSocketServer with a new initializer, taking a path input to a Unix domain socket path, and connecting to it. A new UnixSocket wrapper class was created for wrapping the different socket implementations in Linux and macOS.

Compatibility

All changes are additive or equivalent; there are no breaking changes.

Testing

Enables domain socket tests in the cross-test suite for Swift.

Some cross-tests are failing due to other languages not implementing the UUID type or their implementation doesn't match the spec.
After rebasing on master it seems the cross-tests also seem to not be running right now in CI due to a failure to build the go library

@Jens-G Jens-G added the swift label Mar 9, 2023
@kinoroy kinoroy force-pushed the THRIFT-4838-Swift-unix-domain-socket-support branch from 5179bee to 32a9bfc Compare June 8, 2023 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants