Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] update github workflow for python and include test folder #2789

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jimexist
Copy link
Member

  • Did you create an Apache Jira ticket? (Request account here, not required for trivial changes)
  • If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
  • Did you squash your changes to a single commit? (not required, but preferred)
  • Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"?
  • If your change does not involve any code, include [skip ci] anywhere in the commit message to free up build resources.

@jimexist
Copy link
Member Author

jimexist commented Apr 20, 2023

@fishy this is the follow up of

however i cannot seem to find the cause of it

@Jens-G Jens-G added the python label Apr 20, 2023
@jimexist
Copy link
Member Author

@fishy do you think this maybe the support of uuid in python is missing?

@jimexist jimexist force-pushed the follow-up-python-github-workflow branch from 6b57a86 to bfd2fca Compare April 27, 2023 03:42
@@ -71,50 +71,50 @@ TESTS= $(py_unit_tests)


gen-py/%/__init__.py: ../%.thrift $(THRIFT)
test -f ../v0.16/$(notdir $<) \
&& $(THRIFT) --gen py ../v0.16/$(notdir $<) \
test -f ../$(notdir $<) \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we shouldn't change this one. the ones under v0.16 are for the languages not have uuid implemented yet (and python is one of them).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jimexist I see that you force-pushed on this PR. Did you address the section @fishy mentioned?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no not really - i didn't spend time in python impl in the last year or so

@jimexist jimexist force-pushed the follow-up-python-github-workflow branch from 09a0d0a to fcf3c98 Compare April 28, 2023 06:45
@jimexist jimexist changed the title WIP update github workflow for python [CI] update github workflow for python and include test folder Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants