Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

THRIFT-5774: Add remote client's IP address to ServerContext in TServ… #2959

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

yoelyang
Copy link

@yoelyang yoelyang commented Apr 11, 2024

THRIFT-5774: Add remote client's IP address to ServerContext in TServerEventHandler

Add the remote client's IP address to the ServerContext in TServerEventHandler when creating ServerContext.

  • Did you create an Apache Jira ticket? (Request account here, not required for trivial changes)
  • If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
  • Did you squash your changes to a single commit? (not required, but preferred)
  • Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"?
  • If your change does not involve any code, include [skip ci] anywhere in the commit message to free up build resources.

Copy link
Member

@ctubbsii ctubbsii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not familiar enough with the implementation to know if this is good or not, but I will say that I think this feature would be great to have. My project, Apache Accumulo, has had to do workarounds for years to get the client address, just to log it. It would be great to not have to do that anymore.

@Jens-G Jens-G added the java Pull requests that update Java code label Apr 14, 2024
@Jens-G
Copy link
Member

Jens-G commented Apr 14, 2024

What happens if the transport is not socket based?

@yoelyang
Copy link
Author

What happens if the transport is not socket based?

What happens if the transport is not socket based?

The new commit resolves this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
java Pull requests that update Java code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants