THRIFT-4386 Add Lua 5.3/5.4 support #3012
Conversation
This PR adds support for running with Lua 5.3 and 5.4 while also keeping backwards compatibility with Lua 5.2. Updated ubuntu-jammy dockerfile to install Lua 5.4 for testing.
|
@Jens-G do you know anyone who might be able to review this? If there is currently no active Lua maintainer would it also be acceptable to have the cross tests pass to proof the existing implementation works as expected? If yes I'll move the cross test fixes into this PR :) |
|
+1 agreed |
This PR adds uuid support through a custom TUUID class. Fixed the cross test to confirm the implementation works by cross-testing against Java. Implementation tested on both Lua 5.2 and 5.4.
|
Added 4 more commits to ensure cross testing works as expected. The follow cross tests now work:
The failing netstd tests are the result of 15mb Json data which also times out on netstd client -> netstd server. Note that to get Http working I needed to slightly modify the oneway implementation in the compiler and added a new |
| function TUUIDfromString(str) | ||
| local iterator = string.gmatch(str, "[A-Fa-f0-9][A-Fa-f0-9][A-Fa-f0-9][A-Fa-f0-9]") | ||
| return TUUID:new { | ||
| zero = libluabitwise.buor(libluabitwise.ushiftl(tonumber(iterator(), 16), 16), tonumber(iterator(), 16)), |
There was a problem hiding this comment.
note that bitshifting was added in Lua 5.3, so if support for Lua 5.2 is dropped this implementation and the entire libluabitwise C module can be deleted.
The current usocket implementation drops packages when `send()` returns `EGAIN` or a smaller size than was expected to be send. This implementation will retry up to `SEND_RETRY_COUNT` (5) times before giving up with the original error code. When data was send partially the new implementation tries again with the remaining data. This can happen we sending large chunks of data over a non blocking socket. The error could be reproduced when using the 15mb binary test from netstd.
The Lua HttpTransport didnt close the Http connection properly resulting in an abruptly closed connection. Oneway methods are expected to return before entering the implementation method. Since Lua has no concept of threading the method will always block and cross testing will fail. This implementation adds a new `flushOneway` method to `TTransportBase` which ensures that transports like Http can submit closing responses before entering the oneway method.
thomasbruggink
force-pushed
the
support-lua-5-4
branch
from
7f374d4
to
06af6e8
Compare
This PR adds support for running with Lua 5.3 and 5.4 while also keeping backwards compatibility with Lua 5.1.
Updated ubuntu-jammy dockerfile to install Lua 5.4 for testing.
Fixed cross-testing in a follow up PR to confirm this works with for both Lua versions with the Java client.