Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove dependency on Six #3030

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

remove dependency on Six #3030

wants to merge 1 commit into from

Conversation

a-detiste
Copy link

@fishy
Copy link
Member

fishy commented Aug 28, 2024

There is an open ticket (https://issues.apache.org/jira/browse/THRIFT-5537) and open PRs to drop Python 2 support, which is not done yet.

I don't think we can remove the dependency of six without removing python 2 support.

@Jens-G
Copy link
Member

Jens-G commented Aug 28, 2024

Unfortunately #2588 seems a bit rotten ... it still features endland the number of whitespace changes is as huge as the time when auto-formatting was the new hot thing 🤣 so that seems not an easy task. Any ideas how to solve that mess?

@a-detiste
Copy link
Author

solve that mess?

Well, first declare Python2 officialy unsupported and let vultures tear it appart apiece ;-)

From what I've seen the "one mega PR" approach usualy never completes. At some point people suggests to add typign annotation ;-)

Copy link
Member

@fishy fishy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, first declare Python2 officialy unsupported and let vultures tear it appart apiece ;-)

sounds good to me :)

@fishy
Copy link
Member

fishy commented Aug 28, 2024

we probably should consider this PR part of THRIFT-5537 (add that to PR/commit message title)?

@jimexist
Copy link
Member

would love to see python2 removed but don't have time or bandwidth to actually test it to make it solid.

@Jens-G Jens-G added the python label Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants