THRIFT-1681 #92
Closed
THRIFT-1681 #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @djwatson, thanks for another patch, really appreciate your contributions back to Apache Thrift. looking at it quickly config check are good, compiler looks good, files added to dist (thanks, this often gets missed) and lib with test cases look good, if you could address the following I think this can get merged in
Thanks again |
Makefile.am builds C components - lua files are just copied as scripts. Not sure if this is correct? Test Plan: client/server test in thrift/test/lua Author: Andrew Birchall <[email protected]>
|
These should both be fixed - updated all the headers I found to apache (let me know if I missed any). Updated the TODO with description and remove name |
| t_base_type::t_base tbase = ((t_base_type*)type)->get_base(); | ||
| switch (tbase) { | ||
| case t_base_type::TYPE_STRING: | ||
| out << "'" << value->get_string() << "'"; |
|
@daurnimator could you provide a patch for this? thanks! |
|
Sorry @bufferoverflow, I have no need for this library any more. Just took a quick look at the diff as it passed through my inbox. |
allengeorge
pushed a commit
to allengeorge/thrift
that referenced
this pull request
Jan 1, 2017
Github Pull Request: This closes apache#92
Jens-G
pushed a commit
to Jens-G/thrift
that referenced
this pull request
Apr 14, 2019
Key space isolation extension to IDatabase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LUA thrift library merge from github.com/facebook/fbthrift
Makefile.am builds C components - lua files are just copied as scripts. Not sure if this is correct?
Test Plan:
client/server test in thrift/test/lua
Author: Andrew Birchall [email protected]