Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TIKA-4247 HttpFetcher - add ability to send request headers #1737

Merged
merged 6 commits into from
Aug 7, 2024
Merged

TIKA-4247 HttpFetcher - add ability to send request headers #1737

merged 6 commits into from
Aug 7, 2024

Conversation

nddipiazza
Copy link
Contributor

set headers in a metadata value for "httpRequestHeaders" those will be sent along with http request.

TIKA-4247 HttpFetcher - add ability to send request headers
7c2fb07 
set headers in a metadata value for "httpRequestHeaders"
those will be sent along with http request.
@nddipiazza nddipiazza marked this pull request as ready for review April 29, 2024 18:01
@THausherr
Copy link
Contributor

THausherr commented Aug 7, 2024 •
edited
Loading

This PR looked abandoned in conflict so I tried... most conflict resolution (in dbb8b72) was straightforward except 2 things:

  • setHttpRequestHeaders(List <String>) from main didn't work at all (I suspect that it wasn't covered by tests), see comment. I changed some code but kept main AND branch, i.e. the headers are added twice.
  • parseHeader type change from List to Collection

@THausherr THausherr merged commit 3a0ddc7 into main Aug 7, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartek bartek bartek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nddipiazza @THausherr @bartek