Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

preload driver in connection pool #183

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rmannibucau
Copy link
Contributor

share it for all connections to not have mixed connections (multiple driver instances when fallbacking on TCCL)

Side note: the setters of DataSource(Proxy) should likely recreate the pool when called, not sure it is not already the case but looks fishy so a follow up issue can be needed

…not have mixed connections (multiple driver instances when fallbacking on TCCL)
@@ -335,7 +308,7 @@ protected void connectUsingDriver() throws SQLException {
}
}
if (connection==null) {
throw new SQLException("Driver:"+driver+" returned null for URL:"+driverURL);
throw new SQLException("Driver:"+parent.getDriver()+" returned null for URL:"+driverURL);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

throw new SQLException("Driver:" + parent.getDriver() + " returned null for URL:" + driverURL);

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not the global style so think it would be unlikely to be better with it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants