Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: standardize the HTML, CSS and JSP in the webapps folder. #316

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jbampton
Copy link
Member

@jbampton jbampton commented Jul 4, 2020

Use lowercase HTML tags and attributes.
Add quotes around attributes.
Standardize quotes.
Fix some HTML errors.
Use HTML5 and CSS.
Remove whitespace and blank lines.
Indent HTML and JSP.

@kkolinko
Copy link

kkolinko commented Jul 5, 2020

error.html:

  1. Shouldn't it better be <form method="GET"?
  2. Options shall be closed with . The
    s there are out of place and ignored. (validator.w3.org complains)

@jbampton
Copy link
Member Author

jbampton commented Jul 6, 2020

Hey @kkolinko I removed the br tags and also closed the option tags now.

I also validated the 'error.html' by direct upload and it validates now.

https://validator.w3.org/#validate_by_input

@jbampton jbampton force-pushed the fix-html branch 7 times, most recently from 0b8fdf7 to e844277 Compare July 6, 2020 06:42
@@ -25,11 +25,11 @@ request.setAttribute("tomcatExamplesUrl", "/examples/");
<!DOCTYPE html>
<html lang="en">
<head>
<meta charset="UTF-8" />
<meta charset="UTF-8">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you remove the auto-closing ? It doesn't do any harm. I, personally, prefer the style it was before.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In HTML5 you don't need the auto-closing.
I got the style from MDN.
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/meta

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know, but it does not do any harm either.
This change makes the diff bigger and harder to back-port to the other branches.
I prefer the XHTML style because it is easier to spot errors in the IDE/text editor without copying to W3C validator in the web.

webapps/examples/jsp/cal/cal1.jsp Outdated Show resolved Hide resolved
webapps/examples/jsp/cal/cal1.jsp Outdated Show resolved Hide resolved
webapps/examples/jsp/cal/cal2.jsp Outdated Show resolved Hide resolved
webapps/ROOT/index.jsp Outdated Show resolved Hide resolved
@jbampton
Copy link
Member Author

error.html:

  1. Shouldn't it better be <form method="GET"?
  2. Options shall be closed with . The s there are out of place and ignored. (validator.w3.org complains)

MDN says -> Possible (case insensitive) values
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/form

Screen Shot 2020-08-01 at 5 31 33 am

@jbampton jbampton force-pushed the fix-html branch 8 times, most recently from bb5d215 to 735e437 Compare August 1, 2020 03:59
@jbampton jbampton changed the title Use lowercase HTML tags and attributes. Add quotes around attributes. Standardize the HTML, CSS and JSP in the webapps folder. Aug 1, 2020
@jbampton jbampton force-pushed the fix-html branch 2 times, most recently from 8c818fe to 1e7d050 Compare August 1, 2020 10:07
Use lowercase HTML tags and attributes.
Add quotes around attributes.
Fix some HTML errors.
Use HTML5 and CSS.
Indent HTML and JSP.
Remove whitespace.
Remove blank lines.
Standardize quotes.
@jbampton jbampton changed the title Standardize the HTML, CSS and JSP in the webapps folder. refactor: standardize the HTML, CSS and JSP in the webapps folder. Dec 17, 2020
@michael-o michael-o removed their request for review January 7, 2022 20:49
@ChristopherSchultz
Copy link
Contributor

I'm a -1 on this change mostly because it's so large with so many changes at the same time. If this PR had been the accumulation of several commits e.g. (1) re-format whitespace everywhere with no other changes then (2) remove unnecessary auto-close elements then (3) standardize quoting, etc. then it would have been easier to review, spot things we didn't like, etc. But this is one giant change I'm unwilling to read through to decide if I like every single one of them so, no.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants