-
Notifications
You must be signed in to change notification settings - Fork 691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TOMEE-4318 | TOMEE-4317 - ActiveMQ 6 + Java 17 #1120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Drop related shades.
…tck.tests.constraints.groups.groupconversion.*" as they seem to be broken in BVAL itself with Java 17
jungm
reviewed
Apr 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some small details i noticed 🙂
container/openejb-loader/src/main/java/org/apache/openejb/loader/Embedder.java
Outdated
Show resolved
Hide resolved
rzo1
added a commit
that referenced
this pull request
Apr 23, 2024
* Add tck-mode flag to tomee embedded * Rename tck-mode flag * Add jax-rs tck * Cleanup poms and move jar files * Switch to a dependency of the tck instead of including all the files themselves. For now this is just the staging dependency. * Revert import changes to Container.java and only include the tomee.embedded.tck.enable_tracing * Implement changes proposed by @rzo1 * Fix <snapshots> tag * Some minor changes regarding groupid and tomee version (to allow easy upgrades by mvn release plugin) * Align servlet_adaptor with openejb class from tomee-tck * No need to build a jar or attach sources * Disable fail-on-constrainedto * Fix JAXRSClientIT and JAXRSBasicClientIT Tests * add comments to arquillian.xml * Add a module that generates the signature-file for JAX-RS. * Add licence header * Remove jakarta.staging.repo as a custom repository, as the dependencies we need from there are now in maven central. * Fix Version of tcks * Upgrade Jax-RS Versions to 4.1.0-SNAPSHOT * Fix tcks after merge * Raise baseline to 17 (necessary for JAX-RS) * TOMEE-4318 | TOMEE-4317 - ActiveMQ 6 + Java 17 (#1120) * TOMEE-4317 - ActiveMQ 6.1.0 Drop related shades. * Switch Java Level to 17 * Migrate V11 to V17 class constant in jwt tests * Adds --add-opens for legacy code fragements with libraries not supporting J17+ * Bump maven-plugin-plugin version * Add ScriptEngine implementation for js on Java 15+ * Add ScriptEngine implementation for js in tomee-embedded-maven-plugin as well * Add ScriptEngine implementation for js on Java 15+ * Upgrade Mockito to make it work under J17+ env * Exclude bean validaiton tck tests from "org.hibernate.beanvalidation.tck.tests.constraints.groups.groupconversion.*" as they seem to be broken in BVAL itself with Java 17 * Update GH actions to run with Java 17 * Fix review comments --------- Co-authored-by: Markus Jung <[email protected]> * TOMEE-4319 - CXF 4.1.0-SNAPSHOT * Add tck-mode flag to tomee embedded * Rename tck-mode flag * Add jax-rs tck * Cleanup poms and move jar files * Switch to a dependency of the tck instead of including all the files themselves. For now this is just the staging dependency. * Revert import changes to Container.java and only include the tomee.embedded.tck.enable_tracing * Implement changes proposed by @rzo1 * Fix <snapshots> tag * Some minor changes regarding groupid and tomee version (to allow easy upgrades by mvn release plugin) * Align servlet_adaptor with openejb class from tomee-tck * No need to build a jar or attach sources * Disable fail-on-constrainedto * Fix JAXRSClientIT and JAXRSBasicClientIT Tests * add comments to arquillian.xml * Add a module that generates the signature-file for JAX-RS. * Add licence header * Remove jakarta.staging.repo as a custom repository, as the dependencies we need from there are now in maven central. * Fix Version of tcks * Fix tcks after merge * Add some exclusions for SE-Related tests and disable the TomEE :: TCK :: JAX-RS Signature Test for now * Use latest TCK (3.1.4), Remove duplicate properties Fixes signature tests, which will fail with an odd error (nothing todo with the setup) * Move JAX-RS TCK into child modules in order to download latest 3.1.5 JAX-RS TCK via ant * Run JAX-RS TCK in remote arquillian mode * Exclude currently failing tests: TOMEE-4321 / CXF-9005 --------- Co-authored-by: Sollder1 <[email protected]> Co-authored-by: Swell <[email protected]> Co-authored-by: Richard Zowalla <[email protected]> Co-authored-by: Richard Zowalla <[email protected]> Co-authored-by: Markus Jung <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-> https://ci-builds.apache.org/job/Tomee/job/pull-request-manual/84/