Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TP: error message doesn't display properly when fulfilling an invalid DSR immediately #5188

Closed
dpham692 opened this issue Oct 23, 2020 · 2 comments · Fixed by #5193 or #5198
Closed
Assignees
Labels
bug something isn't working as intended Traffic Portal v1 related to Traffic Portal version 1

Comments

@dpham692
Copy link
Contributor

I'm submitting a ...

  • bug report

Traffic Control components affected ...

  • Traffic Portal

Current behavior:

The error message does not display after user assign a Topology to a DS that has Required Capabilities.

Expected behavior:

The error message should display so user know the DS is updated or not.

Minimal reproduction of the problem with instructions:

Create a new server capability (and do not assign it to any servers), add it as a required capability to a non-topology-based DS, then try to assign a topology to that DS. The update should be prohibited but the error message does not display.

Anything else:

@dpham692 dpham692 added the bug something isn't working as intended label Oct 23, 2020
@rawlinp rawlinp changed the title Message on TP does not display when update Delivery Service TP: error message doesn't display properly when fulfilling an invalid DSR immediately Oct 23, 2020
@rawlinp rawlinp added the Traffic Portal v1 related to Traffic Portal version 1 label Oct 23, 2020
@rawlinp
Copy link
Contributor

rawlinp commented Oct 23, 2020

image

Verified: that is what I see in the chrome dev tools view, so the TO API is properly returning a 400. However, TP is not displaying this error message at the top of the page like it should.

Note: I reproduced this with DSRs enabled (I fulfilled immediately). Without DSRs, the error message displayed properly.

@mitchell852
Copy link
Member

This should not be closed yet as a DSR is incorrectly created/completed when the update to the DS fails API validation. reopening.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something isn't working as intended Traffic Portal v1 related to Traffic Portal version 1
Projects
None yet
3 participants