TP: do not mark DSR (ds request) complete if ds update fails due to validation error #5198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitchell852
added
bug
rawlinp
approved these changes
Oct 26, 2020
rawlinp
pushed a commit
to rawlinp/trafficcontrol
that referenced
this pull request
Oct 26, 2020
…alidation error (apache#5198) * do not mark dsr complete is ds update fails due to validation error * adds CHANGELOG.md entry * updates comment (cherry picked from commit eff7c18)
rawlinp
added a commit
that referenced
this pull request
Oct 26, 2020
…alidation error (#5198) (#5200) * do not mark dsr complete is ds update fails due to validation error * adds CHANGELOG.md entry * updates comment (cherry picked from commit eff7c18) Co-authored-by: Jeremy Mitchell <[email protected]>
ocket8888
pushed a commit
to ocket8888/trafficcontrol
that referenced
this pull request
Oct 29, 2020
…alidation error (apache#5198) * do not mark dsr complete is ds update fails due to validation error * adds CHANGELOG.md entry * updates comment (cherry picked from commit eff7c18)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If DSRs are enabled in traffic_portal_properties.json and your user has the override role, when you make a change to an existing DS, you must create a DSR first and you have the following options:
If you have the override role, you will see the
Fulfill Request Immediatelyoption which will do 2 things:However, if #2 fails API validation, the DSR should not be marked as "complete" but should rather be left in the "submitted" state so it can be modified per the error message.
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
If this is a bug fix, what versions of Traffic Control are affected?
The following criteria are ALL met by this PR