Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TO logs warnings when generating snapshots for topology-based delivery services #5192

Closed
rawlinp opened this issue Oct 26, 2020 · 6 comments · Fixed by #5428 or #5654
Closed

TO logs warnings when generating snapshots for topology-based delivery services #5192

rawlinp opened this issue Oct 26, 2020 · 6 comments · Fixed by #5428 or #5654
Assignees
@rimashah25
Labels
bug something isn't working as intended good first issue first-time committers will find this easy to resolve low impact affects only a small portion of a CDN, and cannot itself break one Traffic Ops related to Traffic Ops
Milestone
5.1.1

Comments

@rawlinp
Copy link
Contributor

rawlinp commented Oct 26, 2020

I'm submitting a ...

  • bug report

Traffic Control components affected ...

  • Traffic Ops

Current behavior:

Traffic Ops logs a warning when generating snapshots for topology-based delivery services:

WARNING: servers.go:364: 2020-10-26T13:35:43.892585-06:00: Creating CRConfig: deliveryservice rawl-http has no regexes, skipping

Expected behavior:

Traffic Ops should not log this warning when generating snapshots for topology-based delivery services.

Minimal reproduction of the problem with instructions:

Create a topology. Assign it to a delivery service. Snapshot the delivery service's CDN.
@rawlinp rawlinp added bug something isn't working as intended Traffic Ops related to Traffic Ops good first issue first-time committers will find this easy to resolve low impact affects only a small portion of a CDN, and cannot itself break one labels Oct 26, 2020
@rimashah25
Copy link
Contributor

I can take this one.

@rimashah25
Copy link
Contributor

Should there be any other expected behavior besides removing the warning log?

@rimashah25 rimashah25 mentioned this issue Jan 12, 2021
Merged
6 tasks
@zrhoffman
Copy link
Member

Should there be any other expected behavior besides removing the warning log?

Nope. Topologies work as expected, so removing the warning is sufficient.

@ocket8888
Copy link
Contributor

Topologies work as expected, but would we still want to log the warning for DSes that don't use them?

@zrhoffman
Copy link
Member

Yep

@rawlinp
Copy link
Contributor Author

rawlinp commented Mar 18, 2021

This was not fixed. I'm still seeing this in 5.1:

WARNING: servers.go:365: 2021-03-18T12:38:27.051636584Z: Creating CRConfig: deliveryservice testqa has no regexes, skipping

Yet the testqa DS has a topology assigned.

@rawlinp rawlinp reopened this Mar 18, 2021
@rawlinp rawlinp added this to the 5.1.1 milestone Mar 18, 2021
@rawlinp rawlinp mentioned this issue Mar 18, 2021
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rimashah25 rimashah25

Labels
bug something isn't working as intended good first issue first-time committers will find this easy to resolve low impact affects only a small portion of a CDN, and cannot itself break one Traffic Ops related to Traffic Ops
Projects
None yet
Milestone
5.1.1
4 participants
@ocket8888 @rawlinp @zrhoffman @rimashah25