Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed TO log warning when generating snapshots for topology-based delivery services #5428

Merged
merged 2 commits into from
Jan 12, 2021
Merged

Fixed TO log warning when generating snapshots for topology-based delivery services #5428

merged 2 commits into from
Jan 12, 2021

Conversation

rimashah25
Copy link
Contributor

What does this PR (Pull Request) do?

Which Traffic Control components are affected by this PR?

  • Traffic Ops
  • Traffic Portal

What is the best way to verify this PR?

Run TP end-to-end tests and TO API tests

If this is a bug fix, what versions of Traffic Control are affected?

The following criteria are ALL met by this PR

  • I have explained why tests are unnecessary
  • I have explained why documentation is unnecessary
  • This PR includes an update to CHANGELOG.md OR such an update is not necessary
  • This PR includes any and all required license headers
  • This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY (see the Apache Software Foundation's security guidelines for details)

Additional Information

The PR doesn't have tests or documentation update as the logic hasn't changed.

@ocket8888 ocket8888 self-assigned this Jan 12, 2021
@mitchell852 mitchell852 added Traffic Ops related to Traffic Ops bug something isn't working as intended labels Jan 12, 2021
ocket8888
ocket8888 approved these changes Jan 12, 2021
View reviewed changes
Copy link
Contributor

@ocket8888 ocket8888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed this fixes the issue, and Zach said it was good to merge once I say so, and the tests pass so I'm saying so.

@ocket8888 ocket8888 merged commit 222da3e into apache:master Jan 12, 2021
@rimashah25 rimashah25 deleted the bugfix/CDN-11782 branch January 12, 2021 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zrhoffman zrhoffman zrhoffman requested changes

@ocket8888 ocket8888 ocket8888 approved these changes

Assignees

@ocket8888 ocket8888

Labels
bug something isn't working as intended Traffic Ops related to Traffic Ops
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TO logs warnings when generating snapshots for topology-based delivery services
4 participants
@rimashah25 @ocket8888 @zrhoffman @mitchell852