Traffic Router integration tests depend on an external Traffic Monitor

[zrhoffman]

I'm submitting a ...

• improvement request (usability, performance, tech debt, etc.)

Traffic Control components affected ...

• Traffic Router

Current behavior:

In order to avoid Comcast/traffic_control#1665, Traffic Router integration tests require an actual Traffic Monitor in order to run:

• trafficcontrol/traffic_router/core/src/test/java/com/comcast/cdn/traffic_control/traffic_router/core/dns/ZoneManagerTest.java

  Line 69 in 5227543

  assertThat("Copy core/src/main/conf/traffic_monitor.properties to core/src/test/conf and set 'traffic_monitor.bootstrap.hosts' to a real traffic monitor", Files.exists(Paths.get(TestBase.monitorPropertiesPath)), equalTo(true));

• trafficcontrol/traffic_router/core/src/test/java/com/comcast/cdn/traffic_control/traffic_router/core/loc/GeoTest.java

  Line 47 in 5227543

  assertThat("Copy core/src/main/conf/traffic_monitor.properties to core/src/test/conf and set 'traffic_monitor.bootstrap.hosts' to a real traffic monitor", Files.exists(Paths.get(TestBase.monitorPropertiesPath)), equalTo(true));

• trafficcontrol/traffic_router/core/src/test/java/com/comcast/cdn/traffic_control/traffic_router/core/router/StatelessTrafficRouterTest.java

  Line 48 in 5227543

  assertThat("Copy core/src/main/conf/traffic_monitor.properties to core/src/test/conf and set 'traffic_monitor.bootstrap.hosts' to a real traffic monitor", Files.exists(Paths.get(TestBase.monitorPropertiesPath)), equalTo(true));

• trafficcontrol/traffic_router/core/src/test/java/com/comcast/cdn/traffic_control/traffic_router/core/util/AbstractResourceWatcherTest.java

  Line 61 in 5227543

  assertThat("Copy core/src/main/conf/traffic_monitor.properties to core/src/test/conf and set 'traffic_monitor.bootstrap.hosts' to a real traffic monitor", Files.exists(Paths.get(TestBase.monitorPropertiesPath)), equalTo(true));

New behavior:

The TR integration tests should use a mock Traffic Monitor server and mock Traffic Ops server like the external tests use:

trafficcontrol/traffic_router/core/src/test/java/com/comcast/cdn/traffic_control/traffic_router/core/external/ExternalTestSuite.java

Lines 106 to 107 in 5227543

	httpDataServer = new HttpDataServer(testHttpServerPort);
	httpDataServer.start(testHttpServerPort);

Minimal reproduction of the problem with instructions:

1. Remove traffic_router/core/src/test/conf/traffic_monitor.properties if it exists
2. Run the integration tests, watch them fail:

   mvn -Djava.library.path=/usr/share/java:/usr/lib64 verify