TR Integration tests updated to use a mock server for TM and TO #6140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattjackson220
added
Traffic Router
mattjackson220
force-pushed
the
TRIntegrationMockServer
branch
from
0af3366
to
1008870
Compare
rawlinp
reviewed
Sep 15, 2021
...src/test/java/org/apache/traffic_control/traffic_router/core/external/ExternalTestSuite.java
Outdated
Show resolved
Hide resolved
shamrickus
approved these changes
Sep 17, 2021
There was a problem hiding this comment.
LGTM, tests pass and code looks fine
I'll let @rawlinp merge in case he wants to re-review.
rawlinp
approved these changes
Sep 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #5992
This PR updates the Traffic Router integration tests to use a mock server for TO and TM.
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
Verify that the TR integration tests pass (mvn -Djava.library.path=/usr/share/java:/usr/lib64 verify)
Verify that a mock server was created for the tests and removed afterward
Verify that the unit and external tests pass
If this is a bugfix, which Traffic Control versions contained the bug?
PR submission checklist