Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The DNSSEC refresh cron job still uses the Perl version #6179

Closed
zrhoffman opened this issue Sep 8, 2021 · 0 comments · Fixed by #6224
Closed

The DNSSEC refresh cron job still uses the Perl version #6179

zrhoffman opened this issue Sep 8, 2021 · 0 comments · Fixed by #6224
Assignees
@rawlinp
Labels
improvement The functionality exists but it could be improved in some way. low impact affects only a small portion of a CDN, and cannot itself break one tools related to tools outside of main components, e.g. 'compare' Traffic Ops related to Traffic Ops
Milestone
TO API v1 removal

Comments

@zrhoffman
Copy link
Member

This Improvement request (usability, performance, tech debt, etc.) affects these Traffic Control components:

  • Traffic Ops

Current behavior:

The Traffic Ops DNSSEC refresh cron job still uses the Perl implementation:

trafficcontrol/traffic_ops/etc/cron.d/trafops_dnssec_refresh

Line 18 in a971b6c

*/5 * * * * trafops export PERL5LIB=/opt/traffic_ops/app/local/lib/perl5:/opt/traffic_ops/app/lib; /opt/traffic_ops/app/bin/checks/ToDnssecRefresh.pl -c '{ "base_url": "https://127.0.0.1" }' -l 1 > /var/log/traffic_ops/trafops_dnssec_refresh.log 2>&1

New behavior:

The cron job should use the Go implementation (/traffic_ops/app/bin/checks/DnssecRefresh/ToDnssecRefresh.go).
@zrhoffman zrhoffman added Traffic Ops related to Traffic Ops tools related to tools outside of main components, e.g. 'compare' improvement The functionality exists but it could be improved in some way. labels Sep 8, 2021
@zrhoffman zrhoffman added this to the TO API v1 removal milestone Sep 8, 2021
@zrhoffman zrhoffman changed the title The DNSSEC refresh cron job should use the Go rewrite The DNSSEC refresh cron job still uses the Perl version Sep 8, 2021
@zrhoffman zrhoffman added the low impact affects only a small portion of a CDN, and cannot itself break one label Sep 14, 2021
@rawlinp rawlinp self-assigned this Sep 14, 2021
rawlinp added a commit to rawlinp/trafficcontrol that referenced this issue Sep 17, 2021
@rawlinp
Compile ToDnssecRefresh binary into TO rpm, update cron job to use it
fa89941 
Closes: apache#6179
@rawlinp rawlinp mentioned this issue Sep 17, 2021
Merged
4 tasks
ocket8888 pushed a commit that referenced this issue Sep 21, 2021
@rawlinp
Compile ToDnssecRefresh binary into TO rpm, update cron job to use it (…
23ee354 
…#6224)

Closes: #6179
zrhoffman pushed a commit that referenced this issue Sep 21, 2021
@rawlinp @zrhoffman
Compile ToDnssecRefresh binary into TO rpm, update cron job to use it (…
c97f45a 
…#6224)

Closes: #6179
(cherry picked from commit 23ee354)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rawlinp rawlinp

Labels
improvement The functionality exists but it could be improved in some way. low impact affects only a small portion of a CDN, and cannot itself break one tools related to tools outside of main components, e.g. 'compare' Traffic Ops related to Traffic Ops
Projects
None yet
Milestone
TO API v1 removal
Development

Successfully merging a pull request may close this issue.

Compile ToDnssecRefresh binary into TO rpm, update cron job to use it rawlinp/trafficcontrol
2 participants
@rawlinp @zrhoffman