Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

t3c calculates max_origin_connections incorrectly for topology-based delivery services #6806

Closed
rawlinp opened this issue May 3, 2022 · 0 comments · Fixed by #6807
Closed

t3c calculates max_origin_connections incorrectly for topology-based delivery services #6806

rawlinp opened this issue May 3, 2022 · 0 comments · Fixed by #6807
Assignees
@rawlinp
Labels
bug something isn't working as intended cache-config Cache config generation high impact impacts the basic function, deployment, or operation of a CDN low difficulty the estimated level of effort to resolve this issue is low
Milestone
7.0.0

Comments

@rawlinp
Copy link
Contributor

rawlinp commented May 3, 2022

This Bug Report affects these Traffic Control components:

  • Traffic Control Cache Config (t3c, formerly ORT)

Current behavior:

t3c calculates the incorrect number for a delivery service's max_origin_connections when generating header_rewrite configs. It is only using the number of caches in the same cachegroup as the given server, rather than all caches at the same tier of the topology (i.e. in a 2-tier topology -- edge+mid -- it should be using the number of all caches in the mid tier).

Expected behavior:

For DSes that use a topology, t3c should calculate a server's max_origin_connections based upon the number of all caches in the last tier (rather than only caches in that server's same cachegroup).

Steps to reproduce:

Create a topology with more than one cachegroup in the last tier. Create a DS with maxOriginConnections = 100 and assign it to that topology. Queue updates on the DS's CDN. Observe that the generated max_origin_connections option in the hdr_rw_last_<xml_id>.config file for a given cache is calculated based on the number of caches in that cachegroup rather than all cachegroups at that tier.
@rawlinp rawlinp added bug something isn't working as intended high impact impacts the basic function, deployment, or operation of a CDN cache-config Cache config generation low difficulty the estimated level of effort to resolve this issue is low labels May 3, 2022
@rawlinp rawlinp added this to the 7.0.0 milestone May 3, 2022
@rawlinp rawlinp self-assigned this May 3, 2022
@rawlinp rawlinp mentioned this issue May 3, 2022
Merged
4 tasks
rawlinp added a commit to rawlinp/trafficcontrol that referenced this issue May 3, 2022
@rawlinp
Fix max_origin_connections calculation for topology-based DSes
eacd7b5 
Instead of only dividing the maxOriginConnections by the number of
caches in the same cachegroup, divide it by the number of caches in the
same tier.

Closes: apache#6806
srijeet0406 pushed a commit that referenced this issue May 5, 2022
@rawlinp
Fix max_origin_connections calculation for topology-based DSes (#6807)
d7deaec 
Instead of only dividing the maxOriginConnections by the number of
caches in the same cachegroup, divide it by the number of caches in the
same tier.

Closes: #6806
@asf-ci asf-ci mentioned this issue Jun 1, 2022
Merged
4 tasks
zrhoffman pushed a commit to zrhoffman/trafficcontrol that referenced this issue Oct 2, 2022
@rawlinp
Fix max_origin_connections calculation for topology-based DSes (apach…
bfc4b2f 
…e#6807)

Instead of only dividing the maxOriginConnections by the number of
caches in the same cachegroup, divide it by the number of caches in the
same tier.

Closes: apache#6806
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rawlinp rawlinp

Labels
bug something isn't working as intended cache-config Cache config generation high impact impacts the basic function, deployment, or operation of a CDN low difficulty the estimated level of effort to resolve this issue is low
Projects
None yet
Milestone
7.0.0
Development

Successfully merging a pull request may close this issue.

Fix max_origin_connections calculation for topology-based DSes rawlinp/trafficcontrol
1 participant
@rawlinp