Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase State Character Limit #6983

Closed
rsidhaarth opened this issue Jul 25, 2022 · 4 comments · Fixed by #7846
Closed

Increase State Character Limit #6983

rsidhaarth opened this issue Jul 25, 2022 · 4 comments · Fixed by #7846
Labels
bug something isn't working as intended good first issue first-time committers will find this easy to resolve hacktoberfest low difficulty the estimated level of effort to resolve this issue is low low impact affects only a small portion of a CDN, and cannot itself break one Traffic Portal v1 related to Traffic Portal version 1

Comments

@rsidhaarth
Copy link

This Bug Report affects these Traffic Control components:

  • Traffic Portal

Current behavior:

Topologies -> Physical Location

As of now, the state cannot have more than 2 letters.

Expected behavior:

There are many states which have abbreviations of more than 2 letters and up to 4 letters.
@rsidhaarth rsidhaarth added the bug something isn't working as intended label Jul 25, 2022
@ocket8888 ocket8888 added Traffic Portal v1 related to Traffic Portal version 1 low impact affects only a small portion of a CDN, and cannot itself break one low difficulty the estimated level of effort to resolve this issue is low labels Jul 25, 2022
@ocket8888
Copy link
Contributor

Restriction possibly also exists in TO

@rsidhaarth rsidhaarth changed the title Increate State Character Limit Increase State Character Limit Jul 26, 2022
@zrhoffman zrhoffman added the good first issue first-time committers will find this easy to resolve label Jul 26, 2022
@Mehul721
Copy link

Hi,I would like to work on this issue.

@zrhoffman
Copy link
Member

Feel free to create PR when one is ready, and please reach out if you have any questions.

@ntheanh201 ntheanh201 mentioned this issue Oct 24, 2023
Merged
4 tasks
@ntheanh201
Copy link
Contributor

I have fixed this issue, please take a look!

Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug something isn't working as intended good first issue first-time committers will find this easy to resolve hacktoberfest low difficulty the estimated level of effort to resolve this issue is low low impact affects only a small portion of a CDN, and cannot itself break one Traffic Portal v1 related to Traffic Portal version 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

increase state character limit to 4 ntheanh201/trafficcontrol
5 participants
@ocket8888 @zrhoffman @rsidhaarth @ntheanh201 @Mehul721