increase state character limit to 4 #7846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ocket8888
requested changes
Nov 1, 2023
| @@ -42,7 +42,7 @@ var FormPhysLocationController = function(physLocation, $scope, $location, formU | |||
| { name: 'shortName', type: 'text', required: true, maxLength: 100 }, | |||
| { name: 'address', type: 'text', required: true, maxLength: 128 }, | |||
| { name: 'city', type: 'text', required: true, maxLength: 128 }, | |||
| { name: 'state', type: 'text', required: true, maxLength: 2 }, | |||
| { name: 'state', type: 'text', required: true, maxLength: 4 }, | |||
There was a problem hiding this comment.
This should match the limitations set by the API - and currently there is no max length in the API. You might arbitrarily choose something huge like 255 but 5+ characters is actually totally valid and our front-end ought to model that more accurately.
There was a problem hiding this comment.
Should we also set the limit in Traffic Ops API?
There was a problem hiding this comment.
You could do that, but that would be a breaking API change which would necessitate an APIv6, deprecation strategy, and a plan on how to eventually migrate old data to the new, more restrictive format.
It'd be a lot less work to just eliminate the requirement altogether in the UI.
ocket8888
added
bug
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #6983
Increase state character limit to 4
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
If this is a bugfix, which Traffic Control versions contained the bug?
PR submission checklist