Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TP: ensures that the DS view state is not reloaded until the DS update is complete #4273

Merged

Conversation

mitchell852
Copy link
Member

@mitchell852 mitchell852 commented Jan 9, 2020

What does this PR (Pull Request) do?

Which Traffic Control components are affected by this PR?

  • Traffic Portal

What is the best way to verify this PR?

  • Turn dsRequests on in traffic_portal_properties.json
  • Set the overrideRole in traffic_portal_properties.json (i.e. admin)
  • Login to TP as a user with the overrideRole
  • Update an existing delivery service. For example, change the routing name.
  • Fulfill the ds request immediately
  • Notice that the routing name has changed in the Delivery Service URL(s) section

If this is a bug fix, what versions of Traffic Control are affected?

The following criteria are ALL met by this PR

  • This PR includes tests OR I have explained why tests are unnecessary
  • This PR includes documentation OR I have explained why documentation is unnecessary
  • This PR includes an update to CHANGELOG.md OR such an update is not necessary
  • This PR includes any and all required license headers
  • This PR ensures that database migration sequence is correct OR this PR does not include a database migration
  • This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY (see the Apache Software Foundation's security guidelines for details)

@mitchell852 mitchell852 added bug something isn't working as intended Traffic Portal v1 related to Traffic Portal version 1 labels Jan 9, 2020
Copy link
Contributor

@mhoppa mhoppa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested locally works as expected

@rawlinp rawlinp merged commit a9914ee into apache:master Jan 9, 2020
mitchell852 added a commit to mitchell852/trafficcontrol that referenced this pull request Jan 9, 2020
rawlinp pushed a commit that referenced this pull request Jan 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something isn't working as intended Traffic Portal v1 related to Traffic Portal version 1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When a ds request is immediately fulfilled, the DS is not updating in TP
3 participants