Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow '0' as a valid value for TTL field in DNS static entry #4955

Merged
merged 6 commits into from
Aug 17, 2020

Conversation

rimashah25
Copy link
Contributor

@rimashah25 rimashah25 commented Aug 13, 2020

What does this PR (Pull Request) do?

Which Traffic Control components are affected by this PR?

  • Traffic Portal
  • Traffic Ops

What is the best way to verify this PR?

Manual Testing

  1. In Traffic Portal, create a HTTP delivery service
  2. Click on More and then add Static DNS entry
  3. Select a Type and type ttl value as zero (0)
  4. You can create a static DNS entry with a successful message.

Automation Testing

  1. Run CIAB
  2. Run Traffic_Portal locally (make sure the Traffic_Ops url point to CIAB traffic ops url)
  3. Ensure protractor and webdriver-manage are installed.
  4. Run webdriver-manager start
  5. Run protractor config.js from traffic_control/traffic_portal/test/end-to-end/ folder
  6. All 73 specs should pass. 73 specs, 0 failures

If this is a bug fix, what versions of Traffic Control are affected?

The following criteria are ALL met by this PR

  • This PR includes tests
  • This PR does not include documentation
  • This PR includes an update to CHANGELOG.md OR such an update is not necessary
  • This PR includes any and all required license headers
  • This does not include a database migration
  • This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY (see the Apache Software Foundation's security guidelines for details)

Additional Information

@rimashah25 rimashah25 changed the title Bugifx/cdn 10401 Allow '0' as a valid value for TTT field in DNS static entry Aug 14, 2020
@ocket8888 ocket8888 changed the title Allow '0' as a valid value for TTT field in DNS static entry Allow '0' as a valid value for TTL field in DNS static entry Aug 14, 2020
Copy link
Member

@mitchell852 mitchell852 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mitchell852 mitchell852 added Traffic Portal v1 related to Traffic Portal version 1 Traffic Ops related to Traffic Ops bug something isn't working as intended regression bug a bug in existing functionality introduced by a new version and removed bug something isn't working as intended labels Aug 17, 2020
Copy link
Contributor

@ocket8888 ocket8888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works like it says, all unit and client/API integration tests passing.

@ocket8888 ocket8888 merged commit 7517836 into apache:master Aug 17, 2020
@rimashah25 rimashah25 deleted the bugifx/CDN-10401 branch August 18, 2020 15:47
@ocket8888 ocket8888 mentioned this pull request Aug 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
regression bug a bug in existing functionality introduced by a new version Traffic Ops related to Traffic Ops Traffic Portal v1 related to Traffic Portal version 1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Portal: Cannot use "0" as a TTL value for Static DNS entries
3 participants