-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow '0' as a valid value for TTL field in DNS static entry #4955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ocket8888
reviewed
Aug 13, 2020
...ommon/modules/form/deliveryServiceStaticDnsEntry/form.deliveryServiceStaticDnsEntry.tpl.html
Outdated
Show resolved
Hide resolved
rimashah25
changed the title
Bugifx/cdn 10401
Allow '0' as a valid value for TTT field in DNS static entry
Aug 14, 2020
ocket8888
changed the title
Allow '0' as a valid value for TTT field in DNS static entry
Allow '0' as a valid value for TTL field in DNS static entry
Aug 14, 2020
mitchell852
approved these changes
Aug 17, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
mitchell852
added
Traffic Portal v1
related to Traffic Portal version 1
Traffic Ops
related to Traffic Ops
bug
something isn't working as intended
regression bug
a bug in existing functionality introduced by a new version
and removed
bug
something isn't working as intended
labels
Aug 17, 2020
ocket8888
approved these changes
Aug 17, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works like it says, all unit and client/API integration tests passing.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
regression bug
a bug in existing functionality introduced by a new version
Traffic Ops
related to Traffic Ops
Traffic Portal v1
related to Traffic Portal version 1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR (Pull Request) do?
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
Manual Testing
More
and then add Static DNS entry0
)Automation Testing
73 specs, 0 failures
If this is a bug fix, what versions of Traffic Control are affected?
The following criteria are ALL met by this PR
Additional Information