Topologies support for assigning ORG servers to Delivery Services #5164
Conversation
non-empty when the enroller runs it
…ry services (#38) * adds the ability to assign ORG servers to topology-based ds's * adds check for enabled 'assign org servers' button * topologies need cache groups with servers in them now
to that Delivery Service
zrhoffman
added
Traffic Ops
|
Reran API tests and they passed. |
|
API tests failed before due to #5165 which is not caused by this PR. |
|
Seeing this when calling My dataset has only ONE server with ID=1134 fyi... |
A join was not specific enough, so delivery service servers could come from other delivery services. Fixed in 982bac1704 |
There was a problem hiding this comment.
This seems to work the way I'd expect:
- In TP I add a topology to a ds, then I can view the servers for the ds (per the topology) at https://tp.domain.tld/#!/delivery-services/{id}/servers?type={type}
- I can now assign ONLY ORG servers to the ds however, those org servers will not show up at https://tp.domain.tld/#!/delivery-services/{id}/servers?type={type} UNTIL the org cache group is added to the topology.
A bit confusing but isn't everything MSO-related? :P
Indeed, I believe that is how it should work. If the ORG cachegroup isn't in the topology, we don't know how to parent up to the ORG servers. |
zrhoffman
force-pushed
the
top-server-dsid-origin
branch
from
1076fef
to
61c9ee3
Compare
|
Looks like we hit #5165 again, rebased onto master since the fix is merged. |
What does this PR (Pull Request) do?
GET /api/3.0/servers?dsId=#for Topology-based Delivery Services unless the ORG server is assigned to that Delivery Service.Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
GET /servers?dsId=#unless it is assignedThe following criteria are ALL met by this PR