Fixes an issue where multiple interfaces reported by a cache are included in the vitals (bandwidth) #5730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per bug report apache#5695, any and all interfaces returned in polling were used to calculate vitals, such as bytes in or out, bandwidth and more. However, only designated interfaces should be used for calculating such metrics and vitals. As such, this commit will check for monitored interfaces and only use those for the calculations.
Ensure callers for GetVitals must include a valid config and the config should contain interfaces
mitchell852
added
Traffic Monitor
srijeet0406
reviewed
Apr 9, 2021
Remove extra blank line from CHANGELOG Condense test structs for sake of clarity Change log levels to reflect actual logging issues Add logging clarity to missing or empty caches and interfaces
srijeet0406
approved these changes
Apr 15, 2021
ocket8888
pushed a commit
that referenced
this pull request
Apr 26, 2021
…uded in the vitals (bandwidth) (#5730) * Normalizing README.md for MacOS case insensitive discrepancies * Removed whitespace at end of line * Only use monitored interfaces for vitals Per bug report #5695, any and all interfaces returned in polling were used to calculate vitals, such as bytes in or out, bandwidth and more. However, only designated interfaces should be used for calculating such metrics and vitals. As such, this commit will check for monitored interfaces and only use those for the calculations. * Normalized README.md file * Normalized README file * Add bugfix info to CHANGELOG * Check monitor config for nil Ensure callers for GetVitals must include a valid config and the config should contain interfaces * Fix merge issue with CHANGELOG * Address PR feedback. Remove extra blank line from CHANGELOG Condense test structs for sake of clarity Change log levels to reflect actual logging issues Add logging clarity to missing or empty caches and interfaces Co-authored-by: Taylor Frey <[email protected]> (cherry picked from commit 89669fd)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR (Pull Request) do?
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
Unit tests have been added to the Traffic Monitor project to ensure this logic will work.
go test apache/trafficcontrol/traffic_monitor/healthmust passAdditionally, verify Traffic Monitor still continues to report Bandwidth as reported in:
#5558
If this is a bug fix, what versions of Traffic Control are affected?
The following criteria are ALL met by this PR
Additional Information