Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Traffic Ops /deliveryserviceserver IMS requests #5965

Merged
merged 1 commit into from
Jul 8, 2021

Conversation

rob05c
Copy link
Member

@rob05c rob05c commented Jun 21, 2021

Fix Traffic Ops /deliveryserviceserver If-Modified-Since requests.

Includes tests.
Includes changelog.
No docs, no interface change.

  • This PR is not related to any other Issue

Which Traffic Control components are affected by this PR?

  • Traffic Ops

What is the best way to verify this PR?

Run TO tests. Make an IMS request to /deliveryserviceserver newer than the last change, verify a 304 is returned.

If this is a bug fix, what versions of Traffic Control are affected?

5.0.x

The following criteria are ALL met by this PR

  • This PR includes tests OR I have explained why tests are unnecessary
  • This PR includes documentation OR I have explained why documentation is unnecessary
  • This PR includes an update to CHANGELOG.md OR such an update is not necessary
  • This PR includes any and all required license headers
  • This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY (see the Apache Software Foundation's security guidelines for details)

Additional Information

@rob05c rob05c added bug something isn't working as intended Traffic Ops related to Traffic Ops labels Jun 21, 2021
@rob05c
Copy link
Member Author

rob05c commented Jun 22, 2021

Not sure why an unrelated test is failing, but I probably won't have time this week, I'll try to investigate and fix next week

@rob05c
Copy link
Member Author

rob05c commented Jun 22, 2021

Also, just to say: this is pretty important as far as IMS goes: Every t3c (nee ORT) run needs it, and it's a massive endpoint.
Once t3c is doing IMS, this will be critical for scalability.

Copy link
Member

@zrhoffman zrhoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix looks good.
Verified that TestDeliveryServiceServers passes for API v3 and v4 and fails if Traffic Ops is rolled back 1 commit.

@zrhoffman zrhoffman merged commit 1c72915 into apache:master Jul 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something isn't working as intended Traffic Ops related to Traffic Ops
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants