Traffic Ops: log a warning instead of ignoring write errors #5984
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR (Pull Request) do?
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
Ensure the TO API tests still pass. Since this logging only happens on write errors, one way to test the logging would be to set the
traffic_ops_golang.request_timeout
in cdn.conf to 1 and make a request to a certain endpoint which is known to take longer than 1 second to return a response. Alternatively, you could add atime.sleep(5*time.Second)
into some handler and call that instead. You should see a log like the following:If this is a bug fix, what versions of Traffic Control are affected?
4.x, 5.x, master
The following criteria are ALL met by this PR