Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support queueing updates by type and profile #6014

Merged
merged 12 commits into from
Jul 19, 2021

Conversation

srijeet0406
Copy link
Contributor

@srijeet0406 srijeet0406 commented Jul 12, 2021

What does this PR (Pull Request) do?

Which Traffic Control components are affected by this PR?

  • Documentation
  • Traffic Ops
  • CI tests

What is the best way to verify this PR?

Make sure all the API/ unit tests pass.
Manual testing:
Run TO and TP locally.
Go to TP and click on a TYPE that is used in the server table, for example, EDGE.
Under the More dropdown button, you should be able to queue updates for this particular type and any CDN.
Do a similar test for profiles.

If this is a bug fix, what versions of Traffic Control are affected?

  • master

The following criteria are ALL met by this PR

  • This PR includes tests
  • This PR includes documentation
  • This PR includes an update to CHANGELOG.md
  • This PR includes any and all required license headers
  • This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY (see the Apache Software Foundation's security guidelines for details)

Additional Information

@rawlinp rawlinp added new feature A new feature, capability or behavior Traffic Ops related to Traffic Ops labels Jul 12, 2021
traffic_ops/v4-client/server_update_status.go Outdated Show resolved Hide resolved
traffic_ops/traffic_ops_golang/cdn/queue.go Outdated Show resolved Hide resolved
lib/go-tc/servers.go Outdated Show resolved Hide resolved
Copy link
Contributor

@rawlinp rawlinp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code and tests look good, just noticed a small UI issue.

EDIT: there is also a merge conflict in CHANGELOG.md that needs to be resolved

@rawlinp rawlinp added the Traffic Portal v1 related to Traffic Portal version 1 label Jul 19, 2021
@rawlinp
Copy link
Contributor

rawlinp commented Jul 19, 2021

These TP test failures might be related to this PR:

Failures:
1) Traffic Portal - CDN - Admin Role queue CDN updates
  Message:
    Expected false to be truthy.
  Stack:
    Error: Failed expectation
        at Suite.<anonymous> (/home/runner/go/src/github.com/apache/trafficcontrol/traffic_portal/test/integration/specs/CDNs.spec.ts:57:62)
        at Generator.next (<anonymous>)
        at fulfilled (/home/runner/go/src/github.com/apache/trafficcontrol/traffic_portal/test/integration/GeneratedCode/specs/CDNs.spec.js:5:58)
        at runMicrotasks (<anonymous>)
        at processTicksAndRejections (internal/process/task_queues.js:97:5)

2) Traffic Portal - CDN - Admin Role clear CDN updates
  Message:
    Expected false to be truthy.
  Stack:
    Error: Failed expectation
        at Suite.<anonymous> (/home/runner/go/src/github.com/apache/trafficcontrol/traffic_portal/test/integration/specs/CDNs.spec.ts:57:62)
        at Generator.next (<anonymous>)
        at fulfilled (/home/runner/go/src/github.com/apache/trafficcontrol/traffic_portal/test/integration/GeneratedCode/specs/CDNs.spec.js:5:58)
        at runMicrotasks (<anonymous>)
        at processTicksAndRejections (internal/process/task_queues.js:97:5)

3) Traffic Portal - CDN - Operation Role queue CDN updates
  Message:
    Expected false to be truthy.
  Stack:
    Error: Failed expectation
        at Suite.<anonymous> (/home/runner/go/src/github.com/apache/trafficcontrol/traffic_portal/test/integration/specs/CDNs.spec.ts:57:62)
        at Generator.next (<anonymous>)
        at fulfilled (/home/runner/go/src/github.com/apache/trafficcontrol/traffic_portal/test/integration/GeneratedCode/specs/CDNs.spec.js:5:58)
        at runMicrotasks (<anonymous>)
        at processTicksAndRejections (internal/process/task_queues.js:97:5)

4) Traffic Portal - CDN - Operation Role clear CDN updates
  Message:
    Expected false to be truthy.
  Stack:
    Error: Failed expectation
        at Suite.<anonymous> (/home/runner/go/src/github.com/apache/trafficcontrol/traffic_portal/test/integration/specs/CDNs.spec.ts:57:62)
        at Generator.next (<anonymous>)
        at fulfilled (/home/runner/go/src/github.com/apache/trafficcontrol/traffic_portal/test/integration/GeneratedCode/specs/CDNs.spec.js:5:58)
        at runMicrotasks (<anonymous>)
        at processTicksAndRejections (internal/process/task_queues.js:97:5)

490 specs, 4 failures

@srijeet0406
Copy link
Contributor Author

These TP test failures might be related to this PR:

Failures:
1) Traffic Portal - CDN - Admin Role queue CDN updates
  Message:
    Expected false to be truthy.
  Stack:
    Error: Failed expectation
        at Suite.<anonymous> (/home/runner/go/src/github.com/apache/trafficcontrol/traffic_portal/test/integration/specs/CDNs.spec.ts:57:62)
        at Generator.next (<anonymous>)
        at fulfilled (/home/runner/go/src/github.com/apache/trafficcontrol/traffic_portal/test/integration/GeneratedCode/specs/CDNs.spec.js:5:58)
        at runMicrotasks (<anonymous>)
        at processTicksAndRejections (internal/process/task_queues.js:97:5)

2) Traffic Portal - CDN - Admin Role clear CDN updates
  Message:
    Expected false to be truthy.
  Stack:
    Error: Failed expectation
        at Suite.<anonymous> (/home/runner/go/src/github.com/apache/trafficcontrol/traffic_portal/test/integration/specs/CDNs.spec.ts:57:62)
        at Generator.next (<anonymous>)
        at fulfilled (/home/runner/go/src/github.com/apache/trafficcontrol/traffic_portal/test/integration/GeneratedCode/specs/CDNs.spec.js:5:58)
        at runMicrotasks (<anonymous>)
        at processTicksAndRejections (internal/process/task_queues.js:97:5)

3) Traffic Portal - CDN - Operation Role queue CDN updates
  Message:
    Expected false to be truthy.
  Stack:
    Error: Failed expectation
        at Suite.<anonymous> (/home/runner/go/src/github.com/apache/trafficcontrol/traffic_portal/test/integration/specs/CDNs.spec.ts:57:62)
        at Generator.next (<anonymous>)
        at fulfilled (/home/runner/go/src/github.com/apache/trafficcontrol/traffic_portal/test/integration/GeneratedCode/specs/CDNs.spec.js:5:58)
        at runMicrotasks (<anonymous>)
        at processTicksAndRejections (internal/process/task_queues.js:97:5)

4) Traffic Portal - CDN - Operation Role clear CDN updates
  Message:
    Expected false to be truthy.
  Stack:
    Error: Failed expectation
        at Suite.<anonymous> (/home/runner/go/src/github.com/apache/trafficcontrol/traffic_portal/test/integration/specs/CDNs.spec.ts:57:62)
        at Generator.next (<anonymous>)
        at fulfilled (/home/runner/go/src/github.com/apache/trafficcontrol/traffic_portal/test/integration/GeneratedCode/specs/CDNs.spec.js:5:58)
        at runMicrotasks (<anonymous>)
        at processTicksAndRejections (internal/process/task_queues.js:97:5)

490 specs, 4 failures

Fixed now

@rawlinp rawlinp merged commit 8523a6e into apache:master Jul 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature A new feature, capability or behavior Traffic Ops related to Traffic Ops Traffic Portal v1 related to Traffic Portal version 1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Queuing Updates by Server Type Add the ability to queue updates for all servers of a given profile
2 participants