-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support queueing updates by type and profile #6014
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rawlinp
reviewed
Jul 12, 2021
rawlinp
added
new feature
A new feature, capability or behavior
Traffic Ops
related to Traffic Ops
labels
Jul 12, 2021
rawlinp
requested changes
Jul 15, 2021
traffic_portal/app/src/common/modules/form/type/form.type.tpl.html
Outdated
Show resolved
Hide resolved
rawlinp
requested changes
Jul 16, 2021
traffic_ops/testing/api/v4/cdn_queue_updates_by_type_profile_test.go
Outdated
Show resolved
Hide resolved
traffic_ops/testing/api/v4/cdn_queue_updates_by_type_profile_test.go
Outdated
Show resolved
Hide resolved
rawlinp
requested changes
Jul 19, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code and tests look good, just noticed a small UI issue.
EDIT: there is also a merge conflict in CHANGELOG.md that needs to be resolved
traffic_portal/app/src/common/modules/form/type/form.type.tpl.html
Outdated
Show resolved
Hide resolved
rawlinp
approved these changes
Jul 19, 2021
These TP test failures might be related to this PR:
|
Fixed now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
new feature
A new feature, capability or behavior
Traffic Ops
related to Traffic Ops
Traffic Portal v1
related to Traffic Portal version 1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR (Pull Request) do?
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
Make sure all the API/ unit tests pass.
Manual testing:
Run TO and TP locally.
Go to TP and click on a
TYPE
that is used in the server table, for example,EDGE
.Under the
More
dropdown button, you should be able to queue updates for this particular type and any CDN.Do a similar test for profiles.
If this is a bug fix, what versions of Traffic Control are affected?
The following criteria are ALL met by this PR
Additional Information