Remove Traffic Router Profile name restrictions #6213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ocket8888
added
Traffic Ops
ocket8888
force-pushed
the
remove-tr-profile-name-restrictions
branch
from
224e7ea
to
c600082
Compare
ocket8888
force-pushed
the
remove-tr-profile-name-restrictions
branch
from
c600082
to
208641b
Compare
ocket8888
force-pushed
the
remove-tr-profile-name-restrictions
branch
from
208641b
to
22ec0e8
Compare
ocket8888
force-pushed
the
remove-tr-profile-name-restrictions
branch
from
22ec0e8
to
00ca751
Compare
3 tasks
ocket8888
force-pushed
the
remove-tr-profile-name-restrictions
branch
from
00ca751
to
56a277a
Compare
ocket8888
force-pushed
the
remove-tr-profile-name-restrictions
branch
from
56a277a
to
31b47ce
Compare
ocket8888
force-pushed
the
remove-tr-profile-name-restrictions
branch
from
31b47ce
to
7c1b6e6
Compare
rawlinp
requested changes
May 18, 2022
ocket8888
force-pushed
the
remove-tr-profile-name-restrictions
branch
from
7c1b6e6
to
752338f
Compare
rawlinp
approved these changes
May 23, 2022
zrhoffman
pushed a commit
to zrhoffman/trafficcontrol
that referenced
this pull request
Oct 2, 2022
* Remove restriction on TR Profiles forcing them to be named like 'CCR%' * Remove incorrect warning from the docs * Rename CIAB Profile to not use legacy TR Acronym * Update CHANGELOG * Remove unnecessary, unused test function from t3c tests * Add string constants for Profile Types to Go library * Switch usages in Go source of raw string for ATS_PROFILE to use constant * Switch usages in Go source of raw string for GROVE_PROFILE to use constant * Switch usages in Go source of raw string for TR_PROFILE to use constant
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes restrictions previously placed on the names of Profiles used by Traffic Routers. From the docs:
However, as can been seen in these changes, that's not even actually strictly true.
TR_prefixes were not supported by the/cdns/domainsTraffic Ops API endpoint.After this PR, however, TO only checks for the correct Profile type (
TRAFFIC_ROUTER), not pattern-matching on the name at all.This is potentially breaking, but only in the extremely weird scenario where Traffic Router servers were using a Profile for some other type of server (since Profile types are immutable, it's not conceivable that someone would have e.g.
TRAFFIC_ROUTER_1as a Profile type, so the Profile type must be some other valid type e.g.TRAFFIC_PORTAL). I believe Traffic Portal would disallow such an assignment anyway, but I'm not certain.This addresses - but doesn't itself close, without #6218 - #2564.
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
Make sure that all tests pass - existing tests do exercise these endpoints, which should prove that
CCR_as a prefix still works. To prove that other things still work, CiaB helps by simply being able to run without the prefix.PR submission checklist