Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade CDNs Traffic Portal view to use AG-Grid tables #6401

Merged
merged 3 commits into from
Mar 4, 2022
Merged

Upgrade CDNs Traffic Portal view to use AG-Grid tables #6401

merged 3 commits into from
Mar 4, 2022

Conversation

ocket8888
Copy link
Contributor

@ocket8888 ocket8888 commented Dec 3, 2021 •
edited by shamrickus
Loading

This closes #6471.

This updates the "CDNs" Traffic Portal page to use AG-Grid instead of JQuery datatables. It's mostly a drop-in replacement, except for two things.

  • A column for CDN ID and another for "Last Updated" have been added - the data was always available but just not shown previously. They're both hidden by default to preserve the old table's structure a bit more.

Which Traffic Control components are affected by this PR?

  • Traffic Portal

What is the best way to verify this PR?

Make sure all the TP tests pass, make sure the new table looks okay. There are a lot of context menu options, so I checked a few of those out, they seem to all be working okay.

PR submission checklist

  • This PR has tests
  • This PR has documentation
  • This PR has a CHANGELOG.md entry
  • This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY

@ocket8888 ocket8888 added Traffic Portal v1 related to Traffic Portal version 1 low impact affects only a small portion of a CDN, and cannot itself break one improvement The functionality exists but it could be improved in some way. labels Dec 3, 2021
@ocket8888 ocket8888 force-pushed the tp/cdns-grid branch 4 times, most recently from b20a257 to bbf1255 Compare December 4, 2021 05:06
@shamrickus shamrickus self-assigned this Jan 5, 2022
@shamrickus
Copy link
Member

Rebase please (has CiaB fix)

shamrickus
shamrickus approved these changes Mar 4, 2022
View reviewed changes
Copy link
Member

@shamrickus shamrickus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shamrickus shamrickus merged commit fdd8ba4 into apache:master Mar 4, 2022
@ocket8888 ocket8888 deleted the tp/cdns-grid branch March 4, 2022 20:46
@github-actions github-actions bot mentioned this pull request Apr 1, 2022
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shamrickus shamrickus shamrickus approved these changes

Assignees

@shamrickus shamrickus

Labels
improvement The functionality exists but it could be improved in some way. low impact affects only a small portion of a CDN, and cannot itself break one Traffic Portal v1 related to Traffic Portal version 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update the CDNs table to use AG-Grid instead of jQuery "dataTables"
2 participants
@ocket8888 @shamrickus