Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removes invalid 'ALL cdn' options from TP #6437

Merged
merged 3 commits into from
Dec 20, 2021
Merged

Removes invalid 'ALL cdn' options from TP #6437

merged 3 commits into from
Dec 20, 2021

Conversation

mitchell852
Copy link
Member

@mitchell852 mitchell852 commented Dec 17, 2021 •
edited
Loading

Closes: #6411

Which Traffic Control components are affected by this PR?

  • Traffic Portal

What is the best way to verify this PR?

  1. Open TP, click on the snapshot (camera) or queue updates (flag) button in the header. ensure the ALL cdn is not an cdn that can be selected for snapshot/queue.
  2. navigate to the ALL cdn page and ensure invalid options do not exist (snapshot, queue, manage dnssec, manage federations and view delivery services)

If this is a bugfix, which Traffic Control versions contained the bug?

  • 6.0.1
  • 5.1.4

PR submission checklist

@mitchell852 mitchell852 added the Traffic Portal v1 related to Traffic Portal version 1 label Dec 17, 2021
@mitchell852 mitchell852 added the regression bug a bug in existing functionality introduced by a new version label Dec 17, 2021
rawlinp
rawlinp approved these changes Dec 20, 2021
View reviewed changes
Copy link
Contributor

@rawlinp rawlinp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does what it says on the tin!

@rawlinp rawlinp merged commit 99bdf78 into apache:master Dec 20, 2021
@zrhoffman zrhoffman added the crconfig-snapshot related in some way to Snapshots (CRConfig) label Dec 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rawlinp rawlinp rawlinp approved these changes

Assignees
No one assigned
Labels
crconfig-snapshot related in some way to Snapshots (CRConfig) regression bug a bug in existing functionality introduced by a new version Traffic Portal v1 related to Traffic Portal version 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Traffic Portal should filter out the "ALL" CDN option for snapshotting and queuing updates
3 participants
@mitchell852 @rawlinp @zrhoffman