Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct parameter name in TOSession.get_parameters_by_profile_id #6590

Merged
merged 3 commits into from
Feb 28, 2022

Conversation

davidc0le
Copy link
Contributor

Closes: #6589

The parameter name as defined in the Python Traffic Control client TOSession.get_parameters_by_profile_id method does not match the name used in the associated decorator, causing an error.

Which Traffic Control components are affected by this PR?

  • Traffic Control Client - Python

What is the best way to verify this PR?

The following Traffic Control Client code should run without errors:

    with TOSession(ats_host, verify_cert=verify_cert) as traffic_ops_api:
        traffic_ops_api.login(to_user, to_pass)
        profiles = traffic_ops_api.get_profiles()[0]
        src = profiles[1] 
        params = traffic_ops_api.get_parameters_by_profile_id(profile_id=src.id)

Without the change in the PR, the error in bug 6589 is seen.

If this is a bugfix, which Traffic Control versions contained the bug?

5.1.x
6.0.2
6.1.0

PR submission checklist

@davidc0le davidc0le changed the title Bugfix/6589 Correct parameter name in TOSession.get_parameters_by_profile_id Feb 28, 2022
@rawlinp rawlinp added bug something isn't working as intended TC Client (python) related to the Python implementation of a TC client labels Feb 28, 2022
Copy link
Member

@zrhoffman zrhoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thank you for your contribution!

@zrhoffman zrhoffman merged commit f24c0b8 into apache:master Feb 28, 2022
@davidc0le davidc0le deleted the bugfix/6589 branch February 28, 2022 19:01
@github-actions github-actions bot mentioned this pull request Mar 1, 2022
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something isn't working as intended TC Client (python) related to the Python implementation of a TC client
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TOSession - Error when calling TOSession.get_parameters_by_profile_id
3 participants