Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed validation response from acme_accounts #6604

Merged
merged 1 commit into from
Mar 2, 2022

Conversation

mattjackson220
Copy link
Contributor

Closes: #6368

This PR fixes the validation error at the /acme_accounts endpoint when the private key is empty or missing


Which Traffic Control components are affected by this PR?

  • Traffic Ops

What is the best way to verify this PR?

Run TO and POST to the /acme_accounts endpoint with privateKey either empty or missing and verify that the response correctly says "privateKey" instead of "private_key"

If this is a bugfix, which Traffic Control versions contained the bug?

PR submission checklist

@mattjackson220 mattjackson220 added bug something isn't working as intended Traffic Ops related to Traffic Ops labels Mar 2, 2022
Copy link
Member

@zrhoffman zrhoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@zrhoffman zrhoffman merged commit 822254d into apache:master Mar 2, 2022
@github-actions github-actions bot mentioned this pull request Apr 1, 2022
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something isn't working as intended Traffic Ops related to Traffic Ops
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect validation message from /acme_accounts
2 participants