Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restores logging the cache status. #6667

Merged
merged 1 commit into from
Mar 30, 2022

Conversation

jrushford
Copy link
Contributor

When the tc-health-client was switched to using the combined
TM CrStates endpoint, the ability to log the cache status was
lost, Issue #6448. PR #6612 adds the cache status field to the
TM CrStates endpoint allowing cache status to be logged again.
This PR adds back the cache status logging.


Which Traffic Control components are affected by this PR?

  • Traffic Control Health Client (tc-health-client)
  • Traffic Control Client

What is the best way to verify this PR?

@ocket8888 ocket8888 added new feature A new feature, capability or behavior low impact affects only a small portion of a CDN, and cannot itself break one tc-health-client Traffic Control Health Client labels Mar 17, 2022
@jrushford
Copy link
Contributor Author

@ocket8888 I'm unable to see any logs for the failing tests. I can't imagine why the Weasel license checks failed. CI issue? Could you restart the CI tests?

@ocket8888
Copy link
Contributor

The license tests failed because

GitHub Actions has encountered an internal error when running your job.

I haven't looked at the other yet, but I'm sure it's the same.

When the tc-health-client was switched to using the combined
TM CrStates endpoint, the ability to log the cache status was
lost, Issue apache#6448.  PR apache#6612 adds the cache status field to the
TM CrStates endpoint allowing cache status to be logged again.
This PR adds back the cache status logging.
Copy link
Contributor

@jpappa200 jpappa200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@rawlinp rawlinp merged commit 55dde3c into apache:master Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
low impact affects only a small portion of a CDN, and cannot itself break one new feature A new feature, capability or behavior tc-health-client Traffic Control Health Client
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants