Obscure sensitive Traffic Portal form fields #6981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ocket8888
added
Traffic Portal v1
shamrickus
reviewed
Aug 1, 2022
...imental/traffic-portal/src/app/shared/obscured-text-input/obscured-text-input.component.html
Outdated
Show resolved
Hide resolved
ocket8888
force-pushed
the
tp/obscure-sensitive-form-fields
branch
from
aab1a67
to
eb98b42
Compare
zrhoffman
pushed a commit
to zrhoffman/trafficcontrol
that referenced
this pull request
Oct 2, 2022
* Add some styling to be able to quickly re-use for obscurable text fields * Remove _ from servers controller * Make the ILO password field obscured by default * obscure DS SSL private keys by default * obscure remap text fields by default * Add CHANGELOG entry * Fix JSDoc required on both getter and setter of a single property * Enumerate the allowable values of an HTML "autocomplete" attribute * Add a reusable component that allows toggling revealing sensitive text * Switch login component to use new obscured text input * Switch server ILO password to use new obscurable text component * Obscure "Header Rewrite" Delivery Service fields by default * Update CHANGELOG * Fix missing module import in unit tests * Fix incorrect selectors in e2e tests * Remove tabindex putting focus on non-interactable element
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This obscures sensitive text fields.
<textarea>fields display blurred text except on hover or while being interacted with (e.g. holding down tap on mobile), and simple<input/>fields areinput[type="password"]s by default, with a button that changes them toinput[type="text]s (and back again).Partially addresses #6953.
The fields obscured are:
This also adds a re-usable component to the experimental Traffic Portal v2 that provides the
<input>typeattribute swapping as an Angular Material Forms-compatible form control value accessor, and uses it in place of the inline solution currently used on the login page as well as for the server details page's ILO Password field.Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
Make sure the provided unit tests for the new TPv2 component have sufficient coverage and pass. Actual functionality is minimally impacted, so existing e2e tests should all still pass.
PR submission checklist