Traffic Stats: reuse http influx client #7022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of creating a new http influx client with each request, reuse the existing client. This should prevent connection leaks when an old client is discarded for a new one but connections are still active on the old one (and therefore not closed by the `Close` function).
rawlinp
added
bug
ocket8888
added
the
low impact
ocket8888
approved these changes
Aug 15, 2022
zrhoffman
pushed a commit
to zrhoffman/trafficcontrol
that referenced
this pull request
Oct 2, 2022
Instead of creating a new http influx client with each request, reuse the existing client. This should prevent connection leaks when an old client is discarded for a new one but connections are still active on the old one (and therefore not closed by the `Close` function).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of creating a new http influx client with each request, reuse
the existing client. This should prevent connection leaks when an old
client is discarded for a new one but connections are still active on
the old one (and therefore not closed by the
Closefunction).Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
Run Traffic Stats and watch the number of open connections to influxdb. The connection counts should remain steady without climbing indefinitely.
If this is a bugfix, which Traffic Control versions contained the bug?
PR submission checklist