Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dev CiaB: Prefix Traffic Monitor profile name with TM profile prefix #7175

Merged
merged 1 commit into from
Nov 7, 2022
Merged

Dev CiaB: Prefix Traffic Monitor profile name with TM profile prefix #7175

merged 1 commit into from
Nov 7, 2022

Conversation

zrhoffman
Copy link
Member

This PR fixes an issue in CDN in a Box for Developers where monitoring.json does not contain any parameters.

This makes the TR Ultimate Test Harness GitHub Actions workflow pass again.

Which Traffic Control components are affected by this PR?

  • CDN in a Box for Developers

What is the best way to verify this PR?

  1. Start CDN in a Box for Developers

    docker-compose up

  2. Take a new snapshot of the dev CDN

  3. Go to https://localhost:444/configs/monitoring and verify the config contains these parameters:

    • health.polling.interval
    • heartbeat.polling.interval
    • peers.polling.interval
    • tm.polling.interval

If this is a bugfix, which Traffic Control versions contained the bug?

  • master

PR submission checklist

@zrhoffman zrhoffman added bug something isn't working as intended low impact affects only a small portion of a CDN, and cannot itself break one dev-ciab Related to CDN in a Box for Developers labels Nov 7, 2022
@zrhoffman zrhoffman mentioned this pull request Nov 7, 2022
Merged
5 tasks
rimashah25
rimashah25 approved these changes Nov 7, 2022
View reviewed changes
Copy link
Contributor

@rimashah25 rimashah25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM

@ocket8888 ocket8888 merged commit 3721d91 into apache:master Nov 7, 2022
@zrhoffman zrhoffman mentioned this pull request Nov 7, 2022
Merged
4 tasks
@zrhoffman zrhoffman deleted the dev-ciab-tm-profile-prefix branch November 13, 2022 01:31
@zrhoffman zrhoffman mentioned this pull request Nov 14, 2022
Merged
4 tasks
rimashah25 added a commit to rimashah25/trafficcontrol that referenced this pull request Nov 16, 2022
@rimashah25
Revert "Dev CiaB: Prefix Traffic Monitor profile name with TM profile…
25ad2a0 
… prefix (apache#7175)"

This reverts commit 3721d91.
rimashah25 added a commit to rimashah25/trafficcontrol that referenced this pull request Nov 16, 2022
@rimashah25
Revert commits apache#7068, apache#7172, apache#7175
9e9bec1
ocket8888 pushed a commit that referenced this pull request Nov 16, 2022
@rimashah25
Revert Traffic Monitor renaming to rascal (#7190)
02b9f04 
* Revert "Dev CiaB: Prefix Traffic Monitor profile name with TM profile prefix (#7175)"

This reverts commit 3721d91.

* Revert "Renamed rascal migration file to get latest time stamp (#7172)"

This reverts commit f956d76.

* Revert commits #7068, #7172, #7175
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ocket8888 ocket8888 ocket8888 approved these changes

@rimashah25 rimashah25 rimashah25 approved these changes

Assignees
No one assigned
Labels
bug something isn't working as intended dev-ciab Related to CDN in a Box for Developers low impact affects only a small portion of a CDN, and cannot itself break one
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zrhoffman @ocket8888 @rimashah25