-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
t3c: strategies.yaml hash_key only for consistent_hash #7204
Conversation
0acbb86
to
c1f0ffe
Compare
c1f0ffe
to
1011715
Compare
Codecov Report
@@ Coverage Diff @@
## master #7204 +/- ##
=========================================
Coverage 28.37% 28.37%
Complexity 98 98
=========================================
Files 617 617
Lines 69197 69202 +5
Branches 90 90
=========================================
+ Hits 19634 19639 +5
Misses 47754 47754
Partials 1809 1809
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
5820e29
to
6b52bb9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, just need to remove the typo in CHANGELOG.md
6b52bb9
to
b69a885
Compare
The t3c strategies.yaml file when generating a strategy always populates the hash_key yaml field although it only applies to consistent_hash policy.
Currently with this configuration ATS 9.2 will bump into the unexpected hash_key field for non consistent_hash policy and abort loading the strategies file entirely.
Note the ATS docs here where hash_key only applies to consistent_hash policy.
https://docs.trafficserver.apache.org/en/latest/admin-guide/files/strategies.yaml.en.html?highlight=strategies#strategies-definitions
Which Traffic Control components are affected by this PR?
t3c
, formerly ORT)What is the best way to verify this PR?
Create DS services, one with consistent_hash and another with round robin.
Run t3c to generate strategies.yaml
Ensure that the DS with consistent_hash policy also has a hash_key key/value
Ensure that the DS with round robin (rr_strict or rr_ip) does not have a hash_key entry.
As a bonus, drop the strategies.yaml file into an ats config directory, fire up ATS9.2 and verify that the strategies.yaml file loads without generating an error.
If this is a bugfix, which Traffic Control versions contained the bug?
7.1.0
PR submission checklist
This PR has documentationbug fix