-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add required capabilities to delivery service structure #7224
Add required capabilities to delivery service structure #7224
Conversation
Codecov Report
@@ Coverage Diff @@
## master #7224 +/- ##
============================================
- Coverage 28.37% 28.29% -0.09%
Complexity 98 98
============================================
Files 617 617
Lines 69202 69360 +158
Branches 90 90
============================================
- Hits 19639 19626 -13
- Misses 47754 47922 +168
- Partials 1809 1812 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should have removed deliveryservices_required_capabilities
from API v5 but it doesn't appear to have done that.
traffic_ops/traffic_ops_golang/deliveryservice/deliveryservices.go
Outdated
Show resolved
Hide resolved
traffic_ops/traffic_ops_golang/deliveryservice/deliveryservices.go
Outdated
Show resolved
Hide resolved
traffic_ops/traffic_ops_golang/deliveryservice/deliveryservices.go
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This now removes deliveryservices_required_capabilities
, but doesn't update the documentation to reflect that.
The new field of a Delivery Service should also be represented in the Delivery Service Overview section.
traffic_ops/app/db/migrations/2022112215022300_add_required_capabilities_to_ds.up.sql
Outdated
Show resolved
Hide resolved
traffic_ops/traffic_ops_golang/deliveryservice/deliveryservices.go
Outdated
Show resolved
Hide resolved
traffic_ops/traffic_ops_golang/deliveryservice/deliveryservices.go
Outdated
Show resolved
Hide resolved
needs conflict resolution to run GHA |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@srijeet0406 trafficcontrol/traffic_ops/testing/api/v5/deliveryservices_required_capabilities_test.go Lines 28 to 31 in 3192836
Also, the API tests still try to create and delete DS required capabilities. See #7801 |
This PR adds the
required capabilities
into thedeliveryservice
structure.Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
Make
CRUD
calls to the delivery service API and make sure that you can add, remove, modify and get required permissions as part of the DS structure.Make sure all the tests pass.
If this is a bugfix, which Traffic Control versions contained the bug?
PR submission checklist