Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

t3c remapdotconfig: remove skip check at mids for nocache/live #7277

Merged
merged 1 commit into from
Jan 13, 2023

Conversation

traeak
Copy link
Contributor

@traeak traeak commented Jan 10, 2023

This bug was introduced with the t3c mustache template PR #7155. Whether or not a DS should have a remap.config line is to be determined by topology.


Which Traffic Control components are affected by this PR?

  • Traffic Control Cache Config (t3c, formerly ORT)

What is the best way to verify this PR?

Create HTTP_NO_CACHE delivery service, assign non edge only topology. Run and ensure remap.config entry exists.

If this is a bugfix, which Traffic Control versions contained the bug?

PR submission checklist

@traeak traeak marked this pull request as ready for review January 11, 2023 15:58
@codecov
Copy link

codecov bot commented Jan 11, 2023

Codecov Report

Merging #7277 (7c16cdc) into master (f489865) will increase coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #7277   +/-   ##
=========================================
  Coverage     28.29%   28.29%           
  Complexity       98       98           
=========================================
  Files           617      617           
  Lines         69650    69650           
  Branches         90       90           
=========================================
+ Hits          19704    19707    +3     
+ Misses        48126    48125    -1     
+ Partials       1820     1818    -2     
Flag Coverage Δ
golib_unit 53.12% <ø> (+0.03%) ⬆️
grove_unit 4.60% <ø> (ø)
t3c_generate_unit 24.96% <ø> (ø)
traffic_monitor_unit 20.43% <ø> (-0.01%) ⬇️
traffic_ops_unit 19.67% <ø> (ø)
traffic_stats_unit 10.41% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
lib/go-atscfg/remapdotconfig.go 76.63% <ø> (+0.45%) ⬆️
traffic_monitor/manager/opsconfig.go 0.00% <0.00%> (ø)
lib/go-atscfg/atscfg.go 58.23% <0.00%> (+0.20%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@zrhoffman zrhoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and tests pass!

@zrhoffman zrhoffman merged commit 30437e3 into apache:master Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants