-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing user in logs bug #7282
Missing user in logs bug #7282
Conversation
…rapAccessLog function
…icious cookie, access_token, and bearer token
Codecov Report
@@ Coverage Diff @@
## master #7282 +/- ##
=========================================
Coverage 26.11% 26.11%
Complexity 98 98
=========================================
Files 648 648
Lines 76057 76080 +23
Branches 90 90
=========================================
+ Hits 19862 19872 +10
- Misses 54362 54373 +11
- Partials 1833 1835 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
…erToken, MojoCookie. Reorged import. Added logging for case where user is not found from cookie.
… unt it test for getCookieToken in wrappers_test.go.
traffic_ops/traffic_ops_golang/routing/middleware/wrappers_test.go
Outdated
Show resolved
Hide resolved
traffic_ops/traffic_ops_golang/routing/middleware/wrappers_test.go
Outdated
Show resolved
Hide resolved
… with username parsing verification.
traffic_ops/traffic_ops_golang/routing/middleware/wrappers_test.go
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks great! All automated tests pass.
Manual verification passed as well.
This bug fix logs user when requests are made to Traffic_Ops when different authentication methods are used.
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
To test this change, you will need to test an API call to TO using 3 different authentication methods(mojolicious, access token, and bearer token).
mojolicious cookie
" -H "Content-Type: application/json" "your TO endpoint
"access token
" -H "Content-Type: application/json" "your TO endpoint
"access token
" -H "Content-Type: application/json" "your TO endpoint
"If this is a bugfix, which Traffic Control versions contained the bug?
Master
PR submission checklist