Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved Fair Queueing Pacing Rate Bps field to Cache Configuration Settings section #7330

Merged

Conversation

rimashah25
Copy link
Contributor

@rimashah25 rimashah25 commented Feb 1, 2023

Fixes: #5557


Which Traffic Control components are affected by this PR?

  • Traffic Portal

What is the best way to verify this PR?

Verify the field (Fair Queueing Pacing Rate Bps) no longer exists in Routing Configuration Settings section for DNS and HTTPS Delivery Service.

If this is a bugfix, which Traffic Control versions contained the bug?

7.0.1

PR submission checklist

Copy link
Contributor

@ocket8888 ocket8888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this looks fine, but the fqPacingRate form field currently only exists on the DNS and HTTP forms. But maybe that's because it was under routing settings. Since it's a caching setting, should it also be added to ANY_MAP? As far as I know, it can be used on them.

Copy link
Contributor

@ocket8888 ocket8888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing confirms that this has no effect on ANY_MAP and therefore is not required on that form.

@ocket8888 ocket8888 merged commit 210ddf1 into apache:master Feb 1, 2023
@rimashah25 rimashah25 deleted the refactor/delivery-service-field branch February 2, 2023 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TP: Fair Queueing Pacing Rate Bps delivery service field should be under Cache Configuration Settings
2 participants