Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new limited role to TO for TR to watch TO resources #7332

Merged
merged 17 commits into from
Feb 2, 2023
Merged

Add new limited role to TO for TR to watch TO resources #7332

merged 17 commits into from
Feb 2, 2023

Conversation

kdamichie
Copy link
Contributor

This PR is a DB entry for a new role called trouter that is for Traffic Router to watch Traffic Ops resources

Which Traffic Control components are affected by this PR?

  • Traffic Ops

What is the best way to verify this PR?

Verify that new Role exists in table for trouter with Capabilities including:

DELIVERY-SERVICE:READ
DNS-SEC:READ
STEERING:READ
FEDERATION-RESOLVER:READ
DS-SECURITY-KEY:READ

If this is a bugfix, which Traffic Control versions contained the bug?

PR submission checklist

zrhoffman
zrhoffman requested changes Feb 1, 2023
View reviewed changes
Copy link
Member

@zrhoffman zrhoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR title: Add new role to user

Is there a different title to describe what #7332 does in more detail?

kdamichie and others added 17 commits February 2, 2023 09:56
@kdamichie kdamichie changed the title Add new role to user Add new limited role to TO for TR to watch TO resources Feb 2, 2023
@kdamichie
Copy link
Contributor Author

Changed PR title to more descriptive name

@zrhoffman zrhoffman added new feature A new feature, capability or behavior Traffic Ops related to Traffic Ops low impact affects only a small portion of a CDN, and cannot itself break one database relating to setup/installation/structure of the Traffic Ops database permissions Dealing with roles/permissions/tenancy labels Feb 2, 2023
zrhoffman
zrhoffman approved these changes Feb 2, 2023
View reviewed changes
Copy link
Member

@zrhoffman zrhoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good (again), thanks!

@zrhoffman zrhoffman merged commit 13f56d4 into apache:master Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zrhoffman zrhoffman zrhoffman approved these changes

Assignees
No one assigned
Labels
database relating to setup/installation/structure of the Traffic Ops database low impact affects only a small portion of a CDN, and cannot itself break one new feature A new feature, capability or behavior permissions Dealing with roles/permissions/tenancy Traffic Ops related to Traffic Ops
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kdamichie @zrhoffman